Add close reason as a comment #863
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #215
Right now, it just puts "Closed as " in the history, which technically works but could be improved. For instance, it doesn't add in the link for close reasons that need a link. This is because the comment is technically the same as the comments for edits, which makes it easy to just patch in like this without extra work, but also limits formatting options since it's just plaintext.
A more sophisticated solution might be to add in "close reason" and "target link" fields to the
post_historiesschema, and do some logic (switch onpost_history_type_id) to format closures differently from other history events.