Add close reason as comment to history #1134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comments are now rendered as markdown, to allow inclusion of e.g. links. Fixes codidact#215
Also add a long dash to separate the "Copy Link" from the comment.
|
This approach will require changes to work together with #1141, will probably rework it into there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments are now rendered as markdown, to allow inclusion of e.g. links.
This MR was inspired by @MoshiKoi 's version (#863), with the main change relative to that version being that I added markdown support to be able to create links. This also means that markdown can be used when the user provides a comment themselves. However, most markdown is again filtered by the PostHistoryScrubber, which only accepts the absolute basics.
Fixes #215