Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-eslint): support implicit configs #683

Merged
merged 2 commits into from
May 28, 2024

Conversation

matejchalk
Copy link
Collaborator

  • The --no-eslintrc flag is only used for inline configs. For config files it broke folder-specific overrides via nested config files.
  • The eslintrc file path parameter is now optional, only patterns need be specified.

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 eslint-plugin labels May 28, 2024
Copy link

github-actions bot commented May 28, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit ce6effe with source commit a8c530a.

🏷️ Categories

🏷️ Category ⭐ Current score ⭐ Previous score 🔄 Score change
Performance 🟡 63 🟡 87 ↓ −23.9
Accessibility 🟢 100 🟢 98 ↑ +1.8
Code style 🟢 100 🟢 99 ↑ +0.9
Code coverage 🟡 70 🟡 70 ↓ +0
Best Practices 🟢 100 🟢 100
SEO 🟡 86 🟡 86
PWA 🟡 63 🟡 63
Bug prevention 🟢 100 🟢 100
Security 🟢 94 🟢 94
Updates 🟡 71 🟡 71
Custom checks 🟡 67 🟡 67

🗃️ Groups

👍 2 groups improved, 👎 2 groups regressed
🔌 Plugin 🗃️ Group ⭐ Current score ⭐ Previous score 🔄 Score change
Lighthouse Performance 🟡 63 🟡 87 ↓ −23.9
Lighthouse Accessibility 🟢 100 🟢 98 ↑ +1.8
ESLint Suggestions 🟢 100 🟢 99 ↑ +0.9
Code coverage Code coverage metrics 🟡 70 🟡 70 ↓ +0

10 other groups are unchanged.

🛡️ Audits

👍 5 audits improved, 👎 10 audits regressed, 7 audits changed without impacting score
🔌 Plugin 🛡️ Audit 📏 Current value 📏 Previous value 🔄 Value change
Lighthouse Minimizes main-thread work 🟥 5.9 s 🟩 2.0 s ↑ +194 %
ESLint Disallow magic numbers 🟩 passed 🟥 4 warnings ↓ −100 %
Lighthouse Avoid large layout shifts 🟩 4 elements found 🟥 5 elements found  −∞ %
Lighthouse Avoid large layout shifts 🟩 15 layout shifts found 🟥 15 layout shifts found  −∞ %
Lighthouse Background and foreground colors have a sufficient contrast ratio 🟩 0 🟥 0  −∞ %
Lighthouse Total Blocking Time 🟥 970 ms 🟩 160 ms ↑ +490 %
Lighthouse Speed Index 🟨 4.8 s 🟩 1.8 s ↑ +167 %
Lighthouse First Contentful Paint 🟨 2.5 s 🟩 1.4 s ↑ +73 %
Lighthouse First Meaningful Paint 🟨 3.0 s 🟩 1.4 s ↑ +110 %
Lighthouse Cumulative Layout Shift 🟩 0.005 🟨 0.147  −∞ %
Lighthouse Max Potential First Input Delay 🟥 630 ms 🟥 380 ms ↑ +67 %
Lighthouse Largest Contentful Paint 🟨 3.5 s 🟨 2.9 s ↑ +19 %
Lighthouse Time to Interactive 🟨 4.2 s 🟩 2.8 s ↑ +49 %
Code coverage Branch coverage 🟨 82 % 🟨 82 %  +0 %
Code coverage Line coverage 🟨 66 % 🟨 66 %  +0 %
Lighthouse Metrics 🟩 4164 🟩 2787 ↑ +49 %
Lighthouse Properly size images 🟥 Potential savings of 240 KiB 🟥 Potential savings of 240 KiB ↓ −66 %
Lighthouse Initial server response time was short 🟩 Root document took 100 ms 🟩 Root document took 0 ms ↑ +3233 %
Lighthouse JavaScript execution time 🟩 0.2 s 🟩 0.1 s ↑ +110 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 432 KiB 🟩 Total size was 432 KiB ↑ +0 %
Lighthouse Server Backend Latencies 🟩 60 ms 🟩 10 ms ↑ +511 %
Lighthouse Uses efficient cache policy on static assets 🟨 11 resources found 🟨 11 resources found ↑ +0 %

228 other audits are unchanged.

@matejchalk matejchalk requested review from Tlacenka and vmasek May 28, 2024 12:37
@matejchalk matejchalk marked this pull request as ready for review May 28, 2024 12:37
@matejchalk matejchalk added 🐛 bug something isn't working and removed 📖 Project documentation improvements or additions to the project documentation labels May 28, 2024
Copy link
Collaborator

@Tlacenka Tlacenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing code is always a pleasure 🎉

@matejchalk matejchalk merged commit a9bb390 into main May 28, 2024
19 checks passed
@matejchalk matejchalk deleted the implicit-eslint-config branch May 28, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants