Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-eslint): revert to explicit config file in nx helper #687

Merged
merged 1 commit into from
May 29, 2024

Conversation

matejchalk
Copy link
Collaborator

@matejchalk matejchalk commented May 29, 2024

Partially reverts #683. Omitting the config file produces warnings. I'm keeping the config file optional, but reverting back to explicit config in Nx helpers since it appears to be introducing more problems if otherwise 😕

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 eslint-plugin labels May 29, 2024
@matejchalk matejchalk requested review from Tlacenka and vmasek May 29, 2024 12:44
Copy link

nx-cloud bot commented May 29, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6c14731. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

Code PushUp

😟 Code PushUp report has regressed – compared target commit ceca519 with source commit 74241e8.

🏷️ Categories

🏷️ Category ⭐ Current score ⭐ Previous score 🔄 Score change
Accessibility 🟢 98 🟢 100 ↓ −1.8
Performance 🟡 89 🟢 90 ↓ −1.5
Code style 🟢 99 🟢 100 ↓ −0.9
Best Practices 🟢 100 🟢 100
SEO 🟡 86 🟡 86
PWA 🟡 63 🟡 63
Bug prevention 🟢 100 🟢 100
Code coverage 🟡 70 🟡 70
Security 🟢 95 🟢 95
Updates 🟢 93 🟢 93
Custom checks 🟡 67 🟡 67

🗃️ Groups

👎 3 groups regressed
🔌 Plugin 🗃️ Group ⭐ Current score ⭐ Previous score 🔄 Score change
Lighthouse Accessibility 🟢 98 🟢 100 ↓ −1.8
Lighthouse Performance 🟡 89 🟢 90 ↓ −1.5
ESLint Suggestions 🟢 99 🟢 100 ↓ −0.9

11 other groups are unchanged.

🛡️ Audits

👎 4 audits regressed, 13 audits changed without impacting score
🔌 Plugin 🛡️ Audit 📏 Current value 📏 Previous value 🔄 Value change
ESLint Disallow magic numbers 🟥 4 warnings 🟩 passed ↑ +∞ %
Lighthouse Background and foreground colors have a sufficient contrast ratio 🟥 0 🟩 0  −∞ %
Lighthouse Max Potential First Input Delay 🟥 330 ms 🟨 140 ms ↑ +140 %
Lighthouse Total Blocking Time 🟩 140 ms 🟩 50 ms ↑ +184 %
Lighthouse Minimizes main-thread work 🟥 2.4 s 🟥 2.0 s ↑ +20 %
Lighthouse Speed Index 🟩 1.5 s 🟩 1.2 s ↑ +21 %
Lighthouse Time to Interactive 🟩 2.6 s 🟩 2.4 s ↑ +8 %
Lighthouse Metrics 🟩 2603 🟩 2401 ↑ +8 %
Lighthouse First Contentful Paint 🟩 1.2 s 🟩 1.1 s ↑ +5 %
Lighthouse First Meaningful Paint 🟩 1.2 s 🟩 1.1 s ↑ +4 %
Lighthouse Largest Contentful Paint 🟨 2.7 s 🟨 2.7 s ↑ +1 %
Lighthouse Server Backend Latencies 🟩 10 ms 🟩 30 ms ↓ −77 %
Lighthouse Initial server response time was short 🟩 Root document took 0 ms 🟩 Root document took 10 ms ↓ −50 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 432 KiB 🟩 Total size was 432 KiB ↓ +0 %
Lighthouse Uses efficient cache policy on static assets 🟨 11 resources found 🟨 11 resources found ↓ +0 %
Lighthouse JavaScript execution time 🟩 0.0 s 🟩 0.0 s ↓ −4 %
Lighthouse Network Round Trip Times 🟩 0 ms 🟩 0 ms ↓ −50 %

231 other audits are unchanged.

Copy link
Collaborator

@Tlacenka Tlacenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢 🙏

@matejchalk matejchalk merged commit ecd8264 into main May 29, 2024
21 checks passed
@matejchalk matejchalk deleted the fix-lint-warnings branch May 29, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧩 eslint-plugin 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants