docgen: add DO statement diagram #140680
Merged
docgen: add DO statement diagram #140680
+16
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
taroface
force-pushed
the
do-statement
branch
from
a76e61d to
84c1558
Compare
taroface
force-pushed
the
do-statement
branch
from
84c1558 to
283e8be
Compare
taroface
force-pushed
the
do-statement
branch
from
283e8be to
38f1665
Compare
|
bors r=DrewKimball |
craig bot
pushed a commit
that referenced
this pull request
Feb 12, 2025
141384: docgen: update DO statement diagram r=DrewKimball a=taroface Correct the SQL diagram for `DO` blocks added in #140680. In the previous statement, `routine_body_str` could not be placed before `LANGUAGE PLPGSQL`, and an empty `DO` statement was allowed. The corrected statement: <img width="374" alt="image" src="https://github.com/user-attachments/assets/21772a89-994b-4836-a79f-09d4d00091bf" /> Epic: none Release note: none Release justification: non-production code change Co-authored-by: Ryan Kuo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a SQL statement diagram for
DO. The diagram looks like this:This is necessary for the accompanying docs PR: cockroachdb/docs#19356
Epic: none
Release note: none
Release justification: non-production code change