Merge #140680

140680: docgen: add DO statement diagram r=DrewKimball a=taroface Added a SQL statement diagram for `DO`. The diagram looks like this: <img width="519" alt="image" src="https://github.com/user-attachments/assets/30feb56a-2085-4fa6-800c-d7920ec4fe49" /> This is necessary for the accompanying docs PR: cockroachdb/docs#19356 Epic: none Release note: none Release justification: non-production code change Co-authored-by: Ryan Kuo <[email protected]>
cockroachdb · Feb 10, 2025 · 562d26b · 562d26b
2 parents 21a181a + 38f1665
commit 562d26b
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 5 deletions.
diff --git a/docs/generated/sql/bnf/BUILD.bazel b/docs/generated/sql/bnf/BUILD.bazel
@@ -124,7 +124,7 @@ FILES = [
     "default_value_column_level",
     "delete_stmt",
     "discard_stmt",
-    "do_stmt",
+    "do",
     "drop_column",
     "drop_constraint",
     "drop_database",

diff --git a/docs/generated/sql/bnf/do.bnf b/docs/generated/sql/bnf/do.bnf
@@ -0,0 +1,3 @@
+do_stmt ::=
+	'DO'  ( ( (  | 'LANGUAGE' ( 'PLPGSQL' ) routine_body_str ) ) )*
+	| 'DO' 'LANGUAGE' ( 'PLPGSQL' ) routine_body_str ( ( (  | 'LANGUAGE' ( 'PLPGSQL' ) routine_body_str ) ) )*
diff --git a/docs/generated/sql/bnf/do_stmt.bnf b/docs/generated/sql/bnf/do_stmt.bnf
diff --git a/pkg/cmd/docgen/diagrams.go b/pkg/cmd/docgen/diagrams.go
@@ -664,6 +664,16 @@ var specs = []stmtSpec{
 		stmt:   "column_table_def",
 		inline: []string{"col_qual_list"},
 	},
+	{
+		name:   "do",
+		stmt:   "do_stmt",
+		inline: []string{"do_stmt_opt_list", "do_stmt_opt_item"},
+		replace: map[string]string{
+			"'SCONST'":                    "",
+			"non_reserved_word_or_sconst": "( 'PLPGSQL' ) routine_body_str",
+		},
+		unlink: []string{"routine_body_str"},
+	},
 	{
 		name:   "for_locking",
 		stmt:   "for_locking_item",

diff --git a/pkg/gen/bnf.bzl b/pkg/gen/bnf.bzl
@@ -124,7 +124,7 @@ BNF_SRCS = [
     "//docs/generated/sql/bnf:default_value_column_level.bnf",
     "//docs/generated/sql/bnf:delete_stmt.bnf",
     "//docs/generated/sql/bnf:discard_stmt.bnf",
-    "//docs/generated/sql/bnf:do_stmt.bnf",
+    "//docs/generated/sql/bnf:do.bnf",
     "//docs/generated/sql/bnf:drop_column.bnf",
     "//docs/generated/sql/bnf:drop_constraint.bnf",
     "//docs/generated/sql/bnf:drop_database.bnf",

diff --git a/pkg/gen/docs.bzl b/pkg/gen/docs.bzl
@@ -137,7 +137,7 @@ DOCS_SRCS = [
     "//docs/generated/sql/bnf:default_value_column_level.bnf",
     "//docs/generated/sql/bnf:delete_stmt.bnf",
     "//docs/generated/sql/bnf:discard_stmt.bnf",
-    "//docs/generated/sql/bnf:do_stmt.bnf",
+    "//docs/generated/sql/bnf:do.bnf",
     "//docs/generated/sql/bnf:drop_column.bnf",
     "//docs/generated/sql/bnf:drop_constraint.bnf",
     "//docs/generated/sql/bnf:drop_database.bnf",