Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django admin: Update portfolio fields on Domain Information #2867

Open
3 of 5 tasks
zandercymatics opened this issue Sep 30, 2024 · 3 comments · May be fixed by #3215
Open
3 of 5 tasks

Django admin: Update portfolio fields on Domain Information #2867

zandercymatics opened this issue Sep 30, 2024 · 3 comments · May be fixed by #3215

Comments

@zandercymatics
Copy link
Contributor

zandercymatics commented Sep 30, 2024

Issue description

In #2934 we updated the layout of Domain Requests for Org model and non-org model requests, and added in conditional logic so that fields that were only relevant to the org model requests disappeared for non org model requests and visa versa. Meanwhile, in #2852 we updated the domain requests so the the filters and domain request table in admin also pull from the portfolio when appropriate and the domain request otherwise. We should now copy what was done for domain requests so domain info has the same logic and layout and ensure that domain (which uses domaininfo inline) receives those layout changes appropriately.

The goal of this ticket should be to make sure all places where we display domain info data now pulls from portfolio when appropriate on the change form views of admin

Acceptance criteria

Domain Information

  • Copy what was done in Update Domain Requests Django admin view #2934 to now apply to Domain Info and Domain
    • this include the conditional showing/hiding of fields
    • also be sure to match the new layout created 2934
  • exception: unlike 2934, domain info (and domain) should not have requested suborganization fields (requested suborg name, city,state )
  • Be especially sure to apply the same suborganization logic that was added into 2934 (see the ACs on that ticket regarding suborganization)

Additional context

Regarding the series of dashes AC, your solution should keep select2 (or at least replace it) as it offers us a performance boost and a search bar.

Refer PR for #2934 so that it is easy to do this change.

Links to other issues

@katypies
Copy link
Contributor

katypies commented Oct 7, 2024

@abroddrick to review this to see if some items need to be split out for domain requests.

@katypies katypies assigned katypies and abroddrick and unassigned katypies Oct 7, 2024
@abroddrick abroddrick changed the title Django admin: Update portfolio fields on Domain Information / Domain Request Django admin: Update portfolio fields on Domain Information Oct 11, 2024
@abroddrick
Copy link
Contributor

Removed domain request items

@h-m-f-t
Copy link
Member

h-m-f-t commented Oct 19, 2024

Right now, this issue and #2826 are both planned next sprint (57). This issue appears to touch select2 which we're proposing be in-sourced in 2826. Paging @abroddrick for awareness and whether these two should be sequenced in a certain order.

@abroddrick abroddrick removed their assignment Oct 24, 2024
@abroddrick abroddrick moved this from 🍦 Backlog to 🎯 Ready in .gov Product Board Oct 24, 2024
@PaulKuykendall PaulKuykendall moved this from 🎯 Ready to 🔖 Planned in .gov Product Board Dec 10, 2024
@rachidatecs rachidatecs moved this from 🔖 Planned to 🏗 In progress in .gov Product Board Dec 10, 2024
@rachidatecs rachidatecs moved this from 🏗 In progress to 👀 In review in .gov Product Board Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment