Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain Info and domain on Django admin pull portfolio info when applicable #2975

Closed
16 tasks
abroddrick opened this issue Oct 24, 2024 · 3 comments · Fixed by #3044
Closed
16 tasks

Domain Info and domain on Django admin pull portfolio info when applicable #2975

abroddrick opened this issue Oct 24, 2024 · 3 comments · Fixed by #3044
Assignees
Labels
carryover Carryover from a previous sprint dev issue is for the dev team Feature: 🧮 Analyst Experience Issue to improve the Analysts workflow Feature: 🏢 Org Model refactor

Comments

@abroddrick
Copy link
Contributor

abroddrick commented Oct 24, 2024

Issue description

For org model Domains/ Domain info, for all portfolio specific fields we should be pulling from the portfolio instead of the domain info object. For example, organization name should come from the portfolio, as changes should be done on the portfolio not on domain info. However, we only want to perform these changes on the django admin tables, all exports (domain exports, analytics pages exports), and any analytics graphs where this applicable.

Acceptance criteria

  • Follow what was done in Add @property to portfolio related fields in Domain Requests #2852
  • Domain Info/Domain fields on django admin should be have a corresponding function that is returning either the stored domain info value or the corresponding portfolio value where appropriate.
  • Filters, sorts and table views on domain info &domain on Django admin are all updated to now pull from the portfolio when needed
  • All reports are updated to use the appropriate fields (this includes those on the analytics page and on the tables)
  • Double check all domain request reports are also using similar logic and update accordingly
  • Do not change the change form (domain/domain info record) view

Additional context

implementation suggestion note: we should be have a corresponding @Property function for each domain info field that is used for reports/analytics/ django admin table/django admin filter. Below are Domain Info/Domain fields but you will not need to handle each one, only create @Property fields IF we are using this value for a report/ analytics board or to display on a table:

  • organization_name
  • generic_org_type (called "organization_type" in Portfolio)
  • federal_agency - should come from federal agency from federal agency entry associated with the portfolio
  • federal_type - should come from federal agency table entry associated with the portfolio
  • senior_official -should come from portfolio
  • address_line1 - should be from portfolio organization address
  • address_line2 - should be from portfolio organization address
  • state_territory - should be from portfolio organization address
  • zipcode - should be from portfolio organization address
  • urbanization - should be from portfolio organization address

Links to other issues

@abroddrick abroddrick added dev issue is for the dev team Feature: 🧮 Analyst Experience Issue to improve the Analysts workflow Feature: 🏢 Org Model labels Oct 24, 2024
@abroddrick abroddrick moved this from 👶 New to 🎯 Ready in .gov Product Board Oct 24, 2024
@CocoByte CocoByte self-assigned this Oct 28, 2024
@PaulKuykendall PaulKuykendall moved this from 🎯 Ready to 🔖 Planned in .gov Product Board Oct 29, 2024
@CocoByte CocoByte moved this from 🔖 Planned to 🏗 In progress in .gov Product Board Oct 31, 2024
@abroddrick
Copy link
Contributor Author

Do to dev huddles today this one is getting closed as a won't do based on finding from the pre-requesite tickets. Aspects of this ticket's AC (that are still applicable) will go into #2867 .

@abroddrick abroddrick closed this as not planned Won't fix, can't repro, duplicate, stale Nov 5, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in .gov Product Board Nov 5, 2024
@abroddrick abroddrick reopened this Nov 6, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 🚗 Parking Lot in .gov Product Board Nov 6, 2024
@abroddrick
Copy link
Contributor Author

After discussing with dev, this ticket is being re-opened but edited to now reflect the ACs that were already completed. #2867 will still contain some of the original ACs that were part of this ticket

@abroddrick abroddrick moved this from 🚗 Parking Lot to 🎯 Ready in .gov Product Board Nov 6, 2024
@abroddrick abroddrick moved this from 🎯 Ready to 🏗 In progress in .gov Product Board Nov 6, 2024
@vickyszuchin vickyszuchin added the carryover Carryover from a previous sprint label Nov 14, 2024
@vickyszuchin
Copy link

Moved all "In progress" sprint 57 tickets to the current sprint (sprint 58), per guidance.

CocoByte added a commit that referenced this issue Dec 6, 2024
…portfolio-fields

Issue #2975 - domain and domain info portfolio fields -[HOTGOV]
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in .gov Product Board Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carryover Carryover from a previous sprint dev issue is for the dev team Feature: 🧮 Analyst Experience Issue to improve the Analysts workflow Feature: 🏢 Org Model refactor
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants