Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Domain Requests Django admin view #2934

Closed
14 of 18 tasks
abroddrick opened this issue Oct 11, 2024 · 1 comment · Fixed by #3040
Closed
14 of 18 tasks

Update Domain Requests Django admin view #2934

abroddrick opened this issue Oct 11, 2024 · 1 comment · Fixed by #3040
Assignees
Labels
dev issue is for the dev team Feature: 🧮 Analyst Experience Issue to improve the Analysts workflow refactor

Comments

@abroddrick
Copy link
Contributor

abroddrick commented Oct 11, 2024

Issue description

For org and non-org domain requests we want to change the layout and add in more conditional logic to show and hide fields. When the org model flag is on we want to show the fields that are relevant to the org model, such as requested suborganization and portfolio, but hide those orgmodel only fields if the org model flag is not on.
miro mock-up

miro providing more information about the conditional fields and what's been moved

Acceptance criteria

  • Follow the miro mockup to move fields and display some fields conditionally note this applies to org and non-org requests
  • ensure all annotations and comments on the two miro mockups are addressed
  • Show series of dashes if a portfolio hasn’t been selected, and do the same with suborganization. (portfolio field, suborg field)
    • Copy the style present on some of the non-select2 fields, like state_territory
  • The "suborganization" field should only appear if a Portfolio has been selected; display should be conditional.
  • The "suborganization" field should only show suborgs associated with the selected portfolio.
    • "Associated" in this context means that the dropdown list should only return suborganizations with the current portfolio.
  • Requested suborganization city/ state should show conditionally if the requested suborganization field is filled in

The below are annotations from the miro mockup, please refer to the miro for pictures. If design adds additional annotations/ comments not listed here they should still included as in scope:

  • For all requests (portfolios AND non-portfolios): Move these fields to a new section with blue-bar that reads "Requested by":
    • Portfolio
    • Suborganization
    • Creator
  • For all requests (portfolios AND non-portfolios): Move "Approved domain" to appear directly below the "Status" field. Should only display if the status is "Approved."
  • Senior official
    • This should pull from the corresponding Senior Official for the portfolio
    • Display role, email, phone below the name (as usual)
    • For superusers AND analysts ... this should be "view only" but the name should link to the corresponding Senior Official record.
  • Hide the following fields for portfolio requests:
    • Other employees
    • No other contacts rationale
    • CISA regional rep first name
    • CISA regional rep last name
    • CISA regional rep email
  • For non org model requests, Cisa regional information should show in the Organization section just at is does currently.
  • For the Type of Org / Org name and mailing address sections on portfolio requests
    • These two sections should pull from the corresponding Portfolio record for the selected agency.
    • Only display the fields that are displayed on the Portfolio page; hide the other fields (e.g. hide "Election office" and "Tribe name").
    • For superusers AND analysts ... this info should be "view only" and the values link to the corresponding Portfolio record.
    • requested suborg contained in this same section as suborganization, right below suborganization. suborganization city and state should also go below the requested sub org
  • The following should be links for Org model requests because they should be pulling from the portfolio (and thus you should edit the portfolio not the domain request if change is desired). All links below should take a user to the portfolio page:
    • federal agency
    • federal type
    • organization type
    • organization address
  • For non federal requests (and either part of a portfolio or not): always show organization name in the Organization section at the top
  • For non federal domain requests (either part of portfolio or not), hide the federal fields (federal type & agency)
  • If org type is "federal" hide organization name ONLY if a portfolio is selected. Otherwise allow for both organization and federal agency to show.

Additional context

Note: This may not be a 5 complexity wise, but with the sheer size of changes and refactors it seems fitting to give it a 5, as whoever takes this should take their time to double check ACs and the miro.

Links to other issues

@abroddrick abroddrick added the dev issue is for the dev team label Oct 11, 2024
@abroddrick abroddrick self-assigned this Oct 11, 2024
@abroddrick abroddrick moved this from 👶 New to 🍦 Backlog in .gov Product Board Oct 11, 2024
@abroddrick abroddrick removed their assignment Oct 24, 2024
@abroddrick abroddrick added the Feature: 🧮 Analyst Experience Issue to improve the Analysts workflow label Oct 24, 2024
@h-m-f-t h-m-f-t moved this from 🍦 Backlog to 🎯 Ready in .gov Product Board Oct 24, 2024
@h-m-f-t
Copy link
Member

h-m-f-t commented Oct 24, 2024

Calling this ready now that refinement is removed.

@asaki222 asaki222 assigned asaki222 and unassigned asaki222 Oct 29, 2024
@PaulKuykendall PaulKuykendall moved this from 🎯 Ready to 🔖 Planned in .gov Product Board Oct 29, 2024
@abroddrick abroddrick moved this from 🔖 Planned to 🏗 In progress in .gov Product Board Nov 7, 2024
@PaulKuykendall PaulKuykendall moved this from 🏗 In progress to 👀 In review in .gov Product Board Nov 7, 2024
dave-kennedy-ecs added a commit that referenced this issue Nov 18, 2024
#2934: Django Admin - Dynamic Domain Request edit page
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in .gov Product Board Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev issue is for the dev team Feature: 🧮 Analyst Experience Issue to improve the Analysts workflow refactor
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

6 participants