Skip to content

Fix case-insensitive email lookup for GitHub Copilot #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrew wants to merge 1 commit into from
Closed

Fix case-insensitive email lookup for GitHub Copilot #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ var knownAgentCommitters = map[string]string{
"209825114+claude[bot]@users.noreply.github.com": "Claude",
"215619710+anthropic-claude[bot]@users.noreply.github.com": "Claude (Anthropic)",
"208546643+claude-code-action[bot]@users.noreply.github.com": "Claude Code Action",
"198982749+Copilot@users.noreply.github.com": "GitHub Copilot (agent)",
"198982749+copilot@users.noreply.github.com": "GitHub Copilot (agent)",
"167198135+copilot[bot]@users.noreply.github.com": "GitHub Copilot (chat)",
"206951365+cursor[bot]@users.noreply.github.com": "Cursor",
"215057067+openai-codex[bot]@users.noreply.github.com": "OpenAI Codex",
Expand Down
60 changes: 52 additions & 8 deletions utils_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,61 @@ import (
"testing"
)

func TestIdentifyAgentCommitterEmail(t *testing.T) {
name, exists := IdentifyAgentCommitterEmail("209825114+claude[bot]@users.noreply.github.com")
if name != "Claude" || exists != true {
t.Errorf(`IdentifyAgentCommitterEmail() for claude address = %q, %v, expecting %#q`, name, exists, "Claude")
func TestIdentifyAgentCommitterEmailAllKnown(t *testing.T) {
for email, expectedName := range knownAgentCommitters {
name, exists := IdentifyAgentCommitterEmail(email)
if !exists || name != expectedName {
t.Errorf("IdentifyAgentCommitterEmail(%q) = %q, %v, want %q, true", email, name, exists, expectedName)
}
}
}

func TestIdentifyAgentCommitterEmailNone(t *testing.T) {
name, exists := IdentifyAgentCommitterEmail("user@example.com")
if name != "" || exists != false {
t.Errorf(`IdentifyAgentCommitterEmail() for non agent address = %q, %v, expecting nothing to exist`, name, exists)
func TestIdentifyAgentCommitterEmailMixedCase(t *testing.T) {
cases := []struct {
input string
wantName string
}{
{"198982749+Copilot@users.noreply.github.com", "GitHub Copilot (agent)"},
{"209825114+CLAUDE[BOT]@USERS.NOREPLY.GITHUB.COM", "Claude"},
{"136622811+CodeRabbitAI[bot]@users.noreply.github.com", "CodeRabbit"},
}

for _, tc := range cases {
name, exists := IdentifyAgentCommitterEmail(tc.input)
if !exists || name != tc.wantName {
t.Errorf("IdentifyAgentCommitterEmail(%q) = %q, %v, want %q, true", tc.input, name, exists, tc.wantName)
}
}
}

func TestIdentifyAgentCommitterEmailWhitespace(t *testing.T) {
cases := []string{
" 209825114+claude[bot]@users.noreply.github.com",
"209825114+claude[bot]@users.noreply.github.com ",
" 209825114+claude[bot]@users.noreply.github.com ",
}

for _, email := range cases {
name, exists := IdentifyAgentCommitterEmail(email)
if !exists || name != "Claude" {
t.Errorf("IdentifyAgentCommitterEmail(%q) = %q, %v, want %q, true", email, name, exists, "Claude")
}
}
}

func TestIdentifyAgentCommitterEmailNotFound(t *testing.T) {
cases := []string{
"user@example.com",
"",
" ",
"claude@anthropic.com",
"not-a-bot@users.noreply.github.com",
}

for _, email := range cases {
name, exists := IdentifyAgentCommitterEmail(email)
if exists || name != "" {
t.Errorf("IdentifyAgentCommitterEmail(%q) = %q, %v, want \"\", false", email, name, exists)
}
}
}
Loading