Fix SpeechRecognizer error handling for "ERROR_SERVER_DISCONNECTED" in Android#125
Open
itsmorty wants to merge 2 commits into
Open
Conversation
Added methods to manage SpeechRecognizer lifecycle. Added new error key `ERROR_SERVER_DISCONNECTED` to `getErrorText` cases. Normal flow: Reuse the same SpeechRecognizer instance (just cancel any pending work and set a new listener) After error: The onError handler destroys and nullifies the recognizer synchronously, so the next start() will create a fresh one
itsmorty
changed the title
Removed unused imports for Handler and Looper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #124
Added methods to manage SpeechRecognizer lifecycle.
Added new error key
ERROR_SERVER_DISCONNECTEDtogetErrorTextcases.Normal flow: Reuse the same SpeechRecognizer instance (just cancel any pending work and set a new listener)
After error: The onError handler destroys and nullifies the recognizer synchronously, so the next start() will create a fresh one
Pull request checklist
Please check if your PR fulfills the following requirements:
Note: I used AI agents (1. GPT-5.1-Codex 2. Gemini 3 Pro, 3. Claude Opus 4.5) with caution to debug/review this issue but still needs a precise review of you maintainer guys :D
@priyankpat @mrbatista