Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename rule to ad-hoc-sub-process #190

Merged
merged 1 commit into from
Feb 18, 2025
Merged

chore: rename rule to ad-hoc-sub-process #190

merged 1 commit into from
Feb 18, 2025

Conversation

nikku
Copy link
Member

@nikku nikku commented Feb 18, 2025

Proposed Changes

As a follow-up to #189, rename the new rule to ad-hoc-sub-process. See prior art. We refer to sub-process predominantly, and -activity does not add any more value.

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@nikku nikku added the rules label Feb 18, 2025
@nikku nikku self-assigned this Feb 18, 2025
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Feb 18, 2025
Copy link
Contributor

@jarekdanielak jarekdanielak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason I thought there would be some conflict between this and the rule from bpmnlint, but the rules are always prefixed with the plugin name. Thanks for the adjustment.

@nikku nikku merged commit 3c48471 into main Feb 18, 2025
3 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 18, 2025
@nikku nikku deleted the ad-hoc-sub-process branch February 18, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants