-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ad-hoc-sub-process-activity
rule + Housekeeping
#189
Conversation
test: adjust FEEL test `@bpmn-io/[email protected]` introduces unary tests which makes `==foo` a valid FEEL expression.
This rules ensures that an Ad-Hoc Sub-Process contains at least one activity. Related to camunda/camunda-modeler#4811
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👏
Question: Why don't we call this rule ==> I'll prepare a PR. |
or even |
Well, we already chose our name via prior art. In bpmnlint, we refer to the thing as |
In this library we are of course 🤣 inconsistent, but majority of rules refers to |
Follow-up PR: #190. |
Released the package as |
Proposed Changes
Add a rule to ensure that an Ad-Hoc Sub-Process contains at least one activity.
Related to camunda/camunda-modeler#4811
Bonus: bpmn dependencies bump.
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/sr
toolCloses {LINK_TO_ISSUE}
orRelated to {LINK_TO_ISSUE}