Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ad-hoc-sub-process-activity rule + Housekeeping #189

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Add ad-hoc-sub-process-activity rule + Housekeeping #189

merged 2 commits into from
Feb 18, 2025

Conversation

jarekdanielak
Copy link
Contributor

Proposed Changes

Add a rule to ensure that an Ad-Hoc Sub-Process contains at least one activity.

Related to camunda/camunda-modeler#4811

Bonus: bpmn dependencies bump.

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

test: adjust FEEL test

`@bpmn-io/[email protected]` introduces unary tests which makes `==foo` a valid FEEL expression.
This rules ensures that an Ad-Hoc Sub-Process contains at least one activity.

Related to camunda/camunda-modeler#4811
@jarekdanielak jarekdanielak added enhancement New feature or request Camunda Cloud labels Feb 17, 2025
@jarekdanielak jarekdanielak self-assigned this Feb 17, 2025
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Feb 17, 2025
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👏

@nikku nikku merged commit a9253e9 into main Feb 18, 2025
3 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 18, 2025
@nikku nikku deleted the ad-hoc-sub branch February 18, 2025 10:26
@nikku
Copy link
Member

nikku commented Feb 18, 2025

Question: Why don't we call this rule ad-hoc-sub-process, mirroring the companion bpmnlint rule?

==> I'll prepare a PR.

@barmac
Copy link
Contributor

barmac commented Feb 18, 2025

Question: Why don't we call this rule ad-hoc-subprocess, mirroring the companion bpmnlint rule?

==> I'll prepare a PR.

or even adhoc-subprocess ;)

@nikku
Copy link
Member

nikku commented Feb 18, 2025

or even adhoc-subprocess ;)

Well, we already chose our name via prior art. In bpmnlint, we refer to the thing as sub-process, hence ad-hoc-sub-process is OK, I think.

@nikku
Copy link
Member

nikku commented Feb 18, 2025

In this library we are of course 🤣 inconsistent, but majority of rules refers to sub-process over subprocess.

@nikku
Copy link
Member

nikku commented Feb 18, 2025

Follow-up PR: #190.

@nikku
Copy link
Member

nikku commented Feb 18, 2025

Released the package as v2.32.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Camunda Cloud enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants