Skip to content

Add test coverage for PRIVATE_KEY_JWT sink credential and 422 PRIVATE_KEY_JWT_NOT_CONFIGURED - #143

Merged
jgarciahospital merged 1 commit into
camaraproject:mainfrom
albertoramosmonagas:fix/issue-75-predictive-connectivity-data
Sep 4, 2026
Merged

jgarciahospital merged 1 commit into
camaraproject:mainfrom
albertoramosmonagas:fix/issue-75-predictive-connectivity-data

Conversation

@albertoramosmonagas

Copy link
Copy Markdown
Contributor

What type of PR is this?

Add one of the following kinds:

  • tests

What this PR does / why we need it:

This PR adds the missing test coverage for PRIVATE_KEY_JWT sink credentials in the Population Density Data API. It includes:

  • A dedicated successful scenario using PRIVATE_KEY_JWT as a valid SinkCredential type.
  • A new 422 PRIVATE_KEY_JWT_NOT_CONFIGURED scenario, aligned with the canonical Commonalities test template.

The scenarios have been adapted to the Population Density Data API operation and response schema.

Which issue(s) this PR fixes:

Fixes camaraproject/PredictiveConnectivityData#75 (same behaviour as Predictive Connectivity Data)

Special notes for reviewers:

Issue #139 does not require additional specification changes, as the jwksUri pre-configuration requirements and PRIVATE_KEY_JWT_NOT_CONFIGURED response are already documented in the API specification. The relevant missing test coverage is addressed by this PR.

A separate inconsistency was identified in the current specification regarding PRIVATE_KEY_JWT_NOT_CONFIGURED being associated with the 400 response instead of the 422 response. This is intentionally left out of scope and should be handled separately.

Changelog input

 release-note
Added test coverage for PRIVATE_KEY_JWT sink credentials, including the successful async flow and the 422 PRIVATE_KEY_JWT_NOT_CONFIGURED error scenario.

@jgarciahospital jgarciahospital left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albertoramosmonagas

Copy link
Copy Markdown
Contributor Author

Hi @sachinvodafone and @maheshc01, can you approve and merge?

@jgarciahospital
jgarciahospital merged commit 3bed1bb into camaraproject:main Sep 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add test coverage for PRIVATE_KEY_JWT sink credential and 422 PRIVATE_KEY_JWT_NOT_CONFIGURED

2 participants