Skip to content

Review issues for r4.1 #132

Description

@Kevsy

Problem description

Placeholder for release-management initial review of #129

Activity

  1. hdamker commented on Aug 7, 2026

    @hdamker
    Contributor

    Same gap as camaraproject/PredictiveConnectivityData#70 also applies here: sinkCredential is only present in the request (population-density-data.yaml:349); no response returns it, so jwksUri can never come back for PRIVATE_KEY_JWT. Only matters if a consumer wants to skip pre-sharing it out-of-band (Commonalities Notification Guide §4.3.1/Appendix A). Also untested.

  2. albertoramosmonagas commented on Aug 31, 2026

    @albertoramosmonagas
    Contributor

    Hi @Kevsy, changes solved here: #141. I think as herbert suggested, we need to create something similar to camaraproject/PredictiveConnectivityData#75, but I think we can close for the moment: #134, #135, #136. WDYT?

  3. albertoramosmonagas commented on Sep 3, 2026

    @albertoramosmonagas
    Contributor

    Hi @Kevsy, I’ve also created PR #143 to address the same test coverage gap described in Predictive Connectivity Data issue #75.

    Based on that, I don’t think there are any further changes needed from our side at this point. Please let me know if you see anything else that still needs to be addressed.

  4. Kevsy commented on Sep 3, 2026

    @Kevsy
    ContributorAuthor

    HI @albertoramosmonagas - yes, I think the PRs only automatically close the first referenced issue when they are comma-separated. I can close them now 👍

  5. jgarciahospital commented on Sep 22, 2026

    @jgarciahospital
    Collaborator

    Closed as all task completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions