Skip to content

Fix dropdown menu doesn't work on some browser #4430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2016
Merged

Fix dropdown menu doesn't work on some browser #4430

merged 1 commit into from
Oct 30, 2016

Conversation

tenkoma
Copy link
Member

@tenkoma tenkoma commented Oct 30, 2016

I Can't select language and version in some browser

It's because Bootstrap Hover Dropdown Library doesn't work on browser enable 'touchstart' Event.(Issue: bootstrap-hover-dropdown #68 )

ex. Chrome 54 on Windows 10(Surface Pro 3 and ThinkPad T440p), Mobile Safari 10(iPad Pro)

Replace behavior by CSS And Remove Dropdown Library.

I test following browsers:

  • Windows 10 Pro(Surface Pro 3): IE11, Edge14, Firefox 49, Chrome 54
  • OS X 10.11(MacbookPro Retina, 2012 Mid): Chrome 54, Safari 10, Firefox 49
  • iPad Pro: Mobile Safari 10

Bootstrap Hover Dropdown Library doesn't work on browser enable 'touchstart' Event.
ex. (Chrome 54 on Windows 10, iPad Safari 10)
Replace behavior in CSS
@markstory markstory added this to the 3.x milestone Oct 30, 2016
@markstory markstory merged commit 2989aba into cakephp:3.0 Oct 30, 2016
@markstory
Copy link
Member

Thanks 👍

@tenkoma tenkoma deleted the fix-does-not-work-dropdown-menu-some-browser branch October 31, 2016 01:37
@tenkoma
Copy link
Member Author

tenkoma commented Oct 31, 2016

@markstory Thanks!

Same problem has older version cookbooks. (1.1, 1.2, 1,3, 2.x)
I want to fix those.
So I add backport pullrequest each branch ? (1.1, 1.2, 1.3, master(for 2.x))

@markstory
Copy link
Member

@tenkoma Additional pull requests for the other versions would be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants