Skip to content

Fix does not work dropdown menu some browser #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tenkoma
Copy link
Member

@tenkoma tenkoma commented Mar 14, 2017

The version selection menu does not work well with some browsers.
Previously, I sent a pull request to fix similar defects.

  • Mobile Safari(iPad) - Tap does not expand the list.
  • Chrome 57, Firefox 52(Surface Pro 3) - Mouseover does not expand the list.

Dropdown reimplemented in CSS (import my commit from cakephp/docs#4430, cakephp/docs#4442, cakephp/docs#4449), and Unnecessary code deleted.

  • Focus support for versions menu ... I implemented the behavior in CSS so delete it.
  • Bootstrap Hover Dropdown ... I confirmed that it is used only in the version selection menu.
  • data-hover="dropdown" ... This attribute was not used by both JavaScript and CSS, so delete it.

Tested in the following environment.

  • macOS X Sierra
    • Safari 10, Firefox 52, Chrome 57
  • Windows 10 (Surfece Pro 3)
    • IE11, Edge14, Firefox 52, Chrome 57
  • iPad
    • Mobile Safari (iOS 10)
  • iPhone 6S Plus
    • Mobile Safari (iOS 10) ... Menu are not hidden when the width is small.

@markstory markstory merged commit 9e30294 into cakephp:master Mar 14, 2017
@tenkoma tenkoma deleted the fix-does-not-work-dropdown-menu-some-browser branch March 14, 2017 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants