fix: feature update api not validating required fields before saving #1527
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #893
Things done
This pull request includes significant updates to the
api-description
YAML files and various Go files to support new feature change types and granular change operations. The most important changes are grouped into updates to the API descriptions and updates to the Go codebase.Updates to API descriptions:
resetSamplingSeed
,variationChanges
,ruleChanges
,prerequisiteChanges
,targetChanges
, andtagChanges
inapi-description/apidocs.swagger.yaml
.featureChangeType
enumeration to specify the type of changes (e.g., CREATE, UPDATE, DELETE) inapi-description/apidocs.swagger.yaml
andapi-description/web-api.swagger.yaml
. [1] [2]featurePrerequisiteChange
,featureRuleChange
,featureTagChange
,featureTargetChange
, andfeatureVariationChange
inapi-description/apidocs.swagger.yaml
andapi-description/web-api.swagger.yaml
. [1] [2]Updates to Go codebase:
ExecuteProgressiveRollout
method inpkg/autoops/api/progressive_rollout.go
and theUpdateFeature
method inpkg/feature/api/feature.go
to handle new change types and fields. [1] [2]pkg/feature/domain/feature.go
. [1] [2] [3]pkg/feature/domain/feature.go
. [1] [2] [3]