fix: feature update api not validating required fields before saving

Signed-off-by: Alessandro Yuichi Okimoto <[email protected]>
bucketeer-io · Feb 21, 2025 · a81d345 · a81d345
1 parent 856fe8e
commit a81d345
Show file tree

Hide file tree

Showing 22 changed files with 6,201 additions and 2,252 deletions.
diff --git a/api-description/apidocs.swagger.yaml b/api-description/apidocs.swagger.yaml
@@ -1692,16 +1692,49 @@ definitions:
         type: boolean
       variations:
         $ref: '#/definitions/featureVariationListValue'
+        description: deprecated
+        title: Legacy full-replacement fields (deprecated)
       prerequisites:
         $ref: '#/definitions/featurePrerequisiteListValue'
+        description: deprecated
       targets:
         $ref: '#/definitions/featureTargetListValue'
+        description: deprecated
       rules:
         $ref: '#/definitions/featureRuleListValue'
+        description: deprecated
       defaultStrategy:
         $ref: '#/definitions/featureStrategy'
       offVariation:
         type: string
+      resetSamplingSeed:
+        type: boolean
+      variationChanges:
+        type: array
+        items:
+          type: object
+          $ref: '#/definitions/featureVariationChange'
+        title: New granular change fields (supporting multiple operations per field)
+      ruleChanges:
+        type: array
+        items:
+          type: object
+          $ref: '#/definitions/featureRuleChange'
+      prerequisiteChanges:
+        type: array
+        items:
+          type: object
+          $ref: '#/definitions/featurePrerequisiteChange'
+      targetChanges:
+        type: array
+        items:
+          type: object
+          $ref: '#/definitions/featureTargetChange'
+      tagChanges:
+        type: array
+        items:
+          type: object
+          $ref: '#/definitions/featureTagChange'
   GatewayUpdatePushBody:
     type: object
     properties:
@@ -2315,6 +2348,14 @@ definitions:
       featureFlagCount:
         type: integer
         format: int32
+  featureChangeType:
+    type: string
+    enum:
+      - UNSPECIFIED
+      - CREATE
+      - UPDATE
+      - DELETE
+    default: UNSPECIFIED
   featureClause:
     type: object
     properties:
@@ -2415,11 +2456,6 @@ definitions:
           $ref: '#/definitions/featurePrerequisite'
       samplingSeed:
         type: string
-      scheduleUpdate:
-        type: array
-        items:
-          type: object
-          $ref: '#/definitions/featureScheduleUpdate'
   featureFeatureLastUsedInfo:
     type: object
     properties:
@@ -2466,6 +2502,16 @@ definitions:
         type: string
       variationId:
         type: string
+  featurePrerequisiteChange:
+    type: object
+    properties:
+      changeType:
+        $ref: '#/definitions/featureChangeType'
+      prerequisite:
+        $ref: '#/definitions/featurePrerequisite'
+    required:
+      - changeType
+      - prerequisite
   featurePrerequisiteListValue:
     type: object
     properties:
@@ -2525,6 +2571,16 @@ definitions:
         items:
           type: object
           $ref: '#/definitions/featureClause'
+  featureRuleChange:
+    type: object
+    properties:
+      changeType:
+        $ref: '#/definitions/featureChangeType'
+      rule:
+        $ref: '#/definitions/featureRule'
+    required:
+      - changeType
+      - rule
   featureRuleListValue:
     type: object
     properties:
@@ -2533,14 +2589,6 @@ definitions:
         items:
           type: object
           $ref: '#/definitions/featureRule'
-  featureScheduleUpdate:
-    type: object
-    properties:
-      feature:
-        $ref: '#/definitions/featureFeature'
-      updateAt:
-        type: string
-        format: int64
   featureSegmentUser:
     type: object
     properties:
@@ -2588,6 +2636,16 @@ definitions:
       - FIXED
       - ROLLOUT
     default: FIXED
+  featureTagChange:
+    type: object
+    properties:
+      changeType:
+        $ref: '#/definitions/featureChangeType'
+      tag:
+        type: string
+    required:
+      - changeType
+      - tag
   featureTarget:
     type: object
     properties:
@@ -2597,6 +2655,16 @@ definitions:
         type: array
         items:
           type: string
+  featureTargetChange:
+    type: object
+    properties:
+      changeType:
+        $ref: '#/definitions/featureChangeType'
+      target:
+        $ref: '#/definitions/featureTarget'
+    required:
+      - changeType
+      - target
   featureTargetListValue:
     type: object
     properties:
@@ -2631,6 +2699,16 @@ definitions:
       - PARTIAL
       - FULL
     default: QUEUED
+  featureVariationChange:
+    type: object
+    properties:
+      changeType:
+        $ref: '#/definitions/featureChangeType'
+      variation:
+        $ref: '#/definitions/bucketeerfeatureVariation'
+    required:
+      - changeType
+      - variation
   featureVariationListValue:
     type: object
     properties:

diff --git a/api-description/web-api.swagger.yaml b/api-description/web-api.swagger.yaml
@@ -8076,6 +8076,14 @@ definitions:
     properties:
       description:
         type: string
+  featureChangeType:
+    type: string
+    enum:
+      - UNSPECIFIED
+      - CREATE
+      - UPDATE
+      - DELETE
+    default: UNSPECIFIED
   featureClauseOperator:
     type: string
     enum:
@@ -8314,11 +8322,6 @@ definitions:
           $ref: '#/definitions/featurePrerequisite'
       samplingSeed:
         type: string
-      scheduleUpdate:
-        type: array
-        items:
-          type: object
-          $ref: '#/definitions/featureScheduleUpdate'
   featureFeatureLastUsedInfo:
     type: object
     properties:
@@ -8522,6 +8525,16 @@ definitions:
         type: string
       variationId:
         type: string
+  featurePrerequisiteChange:
+    type: object
+    properties:
+      changeType:
+        $ref: '#/definitions/featureChangeType'
+      prerequisite:
+        $ref: '#/definitions/featurePrerequisite'
+    required:
+      - changeType
+      - prerequisite
   featurePrerequisiteListValue:
     type: object
     properties:
@@ -8600,6 +8613,16 @@ definitions:
         items:
           type: object
           $ref: '#/definitions/bucketeerfeatureClause'
+  featureRuleChange:
+    type: object
+    properties:
+      changeType:
+        $ref: '#/definitions/featureChangeType'
+      rule:
+        $ref: '#/definitions/featureRule'
+    required:
+      - changeType
+      - rule
   featureRuleListValue:
     type: object
     properties:
@@ -8608,22 +8631,6 @@ definitions:
         items:
           type: object
           $ref: '#/definitions/featureRule'
-  featureScheduleUpdate:
-    type: object
-    properties:
-      feature:
-        $ref: '#/definitions/featureFeature'
-      updateAt:
-        type: string
-        format: int64
-  featureScheduleUpdateListValue:
-    type: object
-    properties:
-      value:
-        type: array
-        items:
-          type: object
-          $ref: '#/definitions/featureScheduleUpdate'
   featureSegment:
     type: object
     properties:
@@ -8707,6 +8714,16 @@ definitions:
       - FIXED
       - ROLLOUT
     default: FIXED
+  featureTagChange:
+    type: object
+    properties:
+      changeType:
+        $ref: '#/definitions/featureChangeType'
+      tag:
+        type: string
+    required:
+      - changeType
+      - tag
   featureTarget:
     type: object
     properties:
@@ -8716,6 +8733,16 @@ definitions:
         type: array
         items:
           type: string
+  featureTargetChange:
+    type: object
+    properties:
+      changeType:
+        $ref: '#/definitions/featureChangeType'
+      target:
+        $ref: '#/definitions/featureTarget'
+    required:
+      - changeType
+      - target
   featureTargetListValue:
     type: object
     properties:
@@ -8784,6 +8811,16 @@ definitions:
           type: string
       forceUpdate:
         type: boolean
+  featureVariationChange:
+    type: object
+    properties:
+      changeType:
+        $ref: '#/definitions/featureChangeType'
+      variation:
+        $ref: '#/definitions/bucketeerfeatureVariation'
+    required:
+      - changeType
+      - variation
   featureVariationListValue:
     type: object
     properties:

diff --git a/manifests/bucketeer/charts/api/values.yaml b/manifests/bucketeer/charts/api/values.yaml
diff --git a/manifests/bucketeer/charts/web/values.yaml b/manifests/bucketeer/charts/web/values.yaml
diff --git a/pkg/autoops/api/progressive_rollout.go b/pkg/autoops/api/progressive_rollout.go
@@ -417,12 +417,23 @@ func (s *AutoOpsService) ExecuteProgressiveRollout(
 			return err
 		}
 		updated, err := feature.Update(
-			nil, nil, nil,
+			nil, // name
+			nil, // description
+			nil, // tags
 			enabled,
-			nil, nil, nil, nil, nil,
+			nil, // archived
 			defaultStrategy,
-			nil,
-			false,
+			nil,   // offVariation
+			false, // resetSamplingSeed
+			nil,   // prerequisites
+			nil,   // targets
+			nil,   // rules
+			nil,   // variations
+			nil,   // prerequisiteChanges
+			nil,   // targetChanges
+			nil,   // ruleChanges
+			nil,   // variationChanges
+			nil,   // tagChanges
 		)
 		if err != nil {
 			return err

diff --git a/pkg/feature/api/feature.go b/pkg/feature/api/feature.go
@@ -763,13 +763,18 @@ func (s *FeatureService) UpdateFeature(
 			req.Tags,
 			req.Enabled,
 			req.Archived,
-			req.Variations,
-			req.Prerequisites,
-			req.Targets,
-			req.Rules,
 			req.DefaultStrategy,
 			req.OffVariation,
 			req.ResetSamplingSeed,
+			req.Prerequisites,
+			req.Targets,
+			req.Rules,
+			req.Variations,
+			req.PrerequisiteChanges,
+			req.TargetChanges,
+			req.RuleChanges,
+			req.VariationChanges,
+			req.TagChanges,
 		)
 		if err != nil {
 			return err