ensure we symlink/junction/copy files/folders ideally on windows rega…#37
Merged
Merged
Conversation
Contributor
Author
|
cc @ef4 |
This was referenced Feb 15, 2018
Merged
stefanpenner
commented
Feb 15, 2018
| fs.writeFileSync(canLinkSrc, ''); | ||
| } catch (e) { | ||
| return false | ||
| return result; |
Contributor
Author
There was a problem hiding this comment.
i guess this line isn't quite correct
Member
|
Related to this comment, I'm concerned that we're adding a lot of complexity here without understanding why it is needed. Do we actually have a reproducible case where files are symlinkable but directories are not? I'd like to avoid adding a lot of code only based on hearsay, for what might turn out to be a rare corner case. |
krisselden
reviewed
Jul 27, 2018
stefanpenner
commented
Jul 27, 2018
rwjblue
approved these changes
Jul 27, 2018
rwjblue
left a comment
rwjblue
left a comment
Member
There was a problem hiding this comment.
LGTM, once we kill that debugger
stefanpenner
force-pushed
the
optimize-windows-link-copy-function
branch
from
July 27, 2018 19:50
7a450a1 to
d5aef0c
Compare
…rdless of if files or folders are symlinkable.
stefanpenner
force-pushed
the
optimize-windows-link-copy-function
branch
2 times, most recently
from
July 27, 2018 20:28
012d5d1 to
9fd6d87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rdless of if files or folders are symlinkable.