Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uninitialized values when parsing zeroes #242

Merged
merged 5 commits into from
Jan 2, 2025

Protect against `max` macro

685d4b1
Select commit
Loading
Failed to load commit list.
Merged

Fix uninitialized values when parsing zeroes #242

Protect against `max` macro
685d4b1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 2, 2025 in 0s

94.85% (+0.08%) compared to 9846df1

View this Pull Request on Codecov

94.85% (+0.08%) compared to 9846df1

Details

Codecov Report

Attention: Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.85%. Comparing base (9846df1) to head (685d4b1).

Files with missing lines Patch % Lines
include/boost/charconv/detail/parser.hpp 90.90% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #242      +/-   ##
===========================================
+ Coverage    94.77%   94.85%   +0.08%     
===========================================
  Files           69       69              
  Lines         9050     9085      +35     
===========================================
+ Hits          8577     8618      +41     
+ Misses         473      467       -6     
Files with missing lines Coverage Δ
test/test_parser.cpp 100.00% <100.00%> (ø)
include/boost/charconv/detail/parser.hpp 83.66% <90.90%> (+3.97%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9846df1...685d4b1. Read the comment docs.