-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix uninitialized values when parsing zeroes #242
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #242 +/- ##
===========================================
+ Coverage 94.77% 94.85% +0.08%
===========================================
Files 69 69
Lines 9050 9085 +35
===========================================
+ Hits 8577 8618 +41
+ Misses 473 467 -6
Continue to review full report in Codecov by Sentry.
|
… `uint64_t` Useful for testing.
`0.e0` will not initialize the significant reference argument. `00[..]0.[0...]` will not initialize exponent nor significant.
BTW: During the rebase I figured it would be easier to (re)use |
Other than that one comment to make windows platforms happy this looks good to me. |
Co-authored-by: Matt Borland <[email protected]>
Fixed. A quick regex search shows a few similar issues, e.g. in |
Opened #251 |
00[..].e0
will not initialize the significant reference argument.00[..]0.[0...]
will not initialize exponent nor significant.Requires