chore(install): stop copying skill prompts to _bmad by default#2182
Open
chore(install): stop copying skill prompts to _bmad by default#2182
Conversation
🤖 Augment PR SummarySummary: This PR changes IDE installation so skills are no longer kept in Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| @@ -0,0 +1,3 @@ | |||
| # Cross-referenced by bmad-edit-prd for prd-purpose.md and data files. | |||
| # Must remain in _bmad/ until those references are refactored. | |||
| install_to_bmad: true | |||
There was a problem hiding this comment.
This manifest only sets install_to_bmad, but loadSkillManifest() treats a top-level manifest as single-entry only when canonicalId or type is present; as-is it will be parsed as multi-entry and getInstallToBmad() will return false for all files. That would allow this skill (and bmad-validate-prd) to be cleaned from _bmad/, breaking the cross-skill _bmad/bmm/... refs in bmad-edit-prd.
Severity: high
Other Locations
src/bmm-skills/2-plan-workflows/bmad-validate-prd/bmad-skill-manifest.yaml:3
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (10)
📝 WalkthroughWalkthroughThis PR reorganizes the skill directory structure from Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
alexeyv
force-pushed
the
chore/stop-copying-prompts-to-bmad
branch
from
f03f862 to
47a622a
Compare
4 tasks
alexeyv
added a commit
to alexeyv/bmad-method-wds-expansion
that referenced
this pull request
Apr 2, 2026
…dencies - Duplicate referenced innards into wds-0-project-setup/resources/ (templates from wds-1, wds-2, wds-4, wds-7 and freya agent guides) - Duplicate project-brief template into saga agent-guide resources - Update folder-guide template refs to use local ./resources/ paths - Change cross-skill invocations to skill:<name> syntax - Replace dead _bmad/wds/docs/method/ refs with skill invocation hints - Preserve config.yaml refs (module-level, handled by installer) Supports bmad-code-org/BMAD-METHOD#2182 which stops copying skill content into _bmad/ at install time.
bmadcode
pushed a commit
to bmad-code-org/bmad-method-wds-expansion
that referenced
this pull request
Apr 2, 2026
* fix: make all skills self-contained by removing _bmad/wds/ path dependencies - Duplicate referenced innards into wds-0-project-setup/resources/ (templates from wds-1, wds-2, wds-4, wds-7 and freya agent guides) - Duplicate project-brief template into saga agent-guide resources - Update folder-guide template refs to use local ./resources/ paths - Change cross-skill invocations to skill:<name> syntax - Replace dead _bmad/wds/docs/method/ refs with skill invocation hints - Preserve config.yaml refs (module-level, handled by installer) Supports bmad-code-org/BMAD-METHOD#2182 which stops copying skill content into _bmad/ at install time. * fix: update broken relative paths in duplicated resource files Fix ../../workflows/ references in copied agent guides that were valid at their original location but broke after duplication into wds-0-project-setup/resources/. Replaced with skill:<name> syntax.
Flip install_to_bmad default from true to false so skill directories are cleaned from _bmad/ after IDE install. Skills are self-contained in their IDE directories (.claude/skills/, etc.) and no longer need duplicate copies in _bmad/. Two skills (bmad-create-prd, bmad-validate-prd) opt back in via explicit manifests because bmad-edit-prd cross-references their data files. Also fixes broken bmm-skills/ path references and corrects the file-ref validator module-to-source mapping. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…_bmad Give bmad-edit-prd its own copy of prd-purpose.md and replace the cross-skill validation workflow reference with a skill invocation, so all three PRD skills are fully self-contained. With no remaining consumers, remove the install_to_bmad flag from manifests, CSV output, the post-install cleanup loop, and the dedicated test file.
Skills are self-contained in IDE directories, so _bmad/ only needs module-level files (config.yaml, _config/). After all IDE setups complete, remove skill directories from _bmad/ via skill-manifest.csv. Also cleans up skill dirs left by older installer versions.
alexeyv
force-pushed
the
chore/stop-copying-prompts-to-bmad
branch
from
7687d1b to
d0bd379
Compare
MartenAngner
added a commit
to whiteport-collective/whiteport-design-studio
that referenced
this pull request
Apr 3, 2026
…ad PR bmad-code-org#23 Remove all _bmad/wds/workflows/ and _bmad/wds/docs/method/ path references from activation files, folder-guide templates, and skill references. Replace with skill:<name> syntax following the self-contained pattern from bmad-method- wds-expansion PR bmad-code-org#23 (BMAD-METHOD bmad-code-org#2182). config.yaml refs preserved — handled by installer as before. Files updated: saga.activation.md, freya.activation.md, all folder-guide templates, alignment-signoff steps, saga/freya reference docs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install_to_bmaddefault fromtruetofalseso skill directories are cleaned from_bmad/after IDE install — skills are self-contained in their IDE directories and no longer need duplicate copiesbmad-edit-prd(bmm-skills/→bmm/)install_to_bmad: trueopt-in manifests forbmad-create-prdandbmad-validate-prd(cross-referenced bybmad-edit-prd)_bmad/bmm/→src/bmm-skills/)Test plan
npm run qualitypasses (204 tests, 0 broken refs, lint clean)test/test-install-to-bmad.jscontract tests updated and passing (10/10)_bmad/no longer contains skill directories (except opted-in ones)bmad-edit-prdskill can resolveprd-purpose.mdat runtime🤖 Generated with Claude Code