Skip to content

fix: add copy-paste command for adversarial review in quick-spec #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikolasdehor wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

fix: add copy-paste command for adversarial review in quick-spec #1910

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-04-review.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,12 @@ Saved to: {finalFile}
[D] Done - exit workflow
[P] Party Mode - get expert feedback before dev

To run adversarial review in a fresh context (recommended for information asymmetry):

\`\`\`
/bmad-review-adversarial-general {finalFile}
Copy link
Copy Markdown
Collaborator

@bmadcode bmadcode Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are going to be updating all language to say Invoke skill {skill-name} since some tools for whatever dumb reason did not follow convention of / command.

\`\`\`

Comment on lines +123 to +128
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Placement breaks narrative flow and creates UX confusion.

The command block interrupts the flow between the menu display (ending line 122) and the "Once you are fully satisfied" guidance (line 131). Readers encounter:

  1. Menu with [R] option
  2. Adversarial review command (lines 123-128)
  3. Horizontal rule
  4. "Once you are fully satisfied... ideally after Adversarial Review"

This creates confusion: Should users select [R] from the menu, or copy-paste the command? Why is there a command outside the menu flow? The quick-dev pattern (lines 131-139) correctly places the command AFTER the explanatory text, not before.

Move lines 123-128 to appear AFTER line 122 (before the horizontal rule at 129) OR integrate into the "Once you are fully satisfied" paragraph at line 131 with contextual explanation.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@src/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-04-review.md` around
lines 123 - 128, Move the standalone adversarial review command block (the
/bmad-review-adversarial-general {finalFile} snippet) so it no longer interrupts
the menu flow: either place that command immediately after the menu display
(i.e., after the content that ends with the menu and before the horizontal rule)
or incorporate the command into the "Once you are fully satisfied" paragraph
that references Adversarial Review, adding a short contextual sentence
explaining when to run /bmad-review-adversarial-general {finalFile} so users
know to choose [R] from the menu OR run the command in a fresh context.

---

Once you are fully satisfied with the spec (ideally after **Adversarial Review** and maybe a few rounds of **Advanced Elicitation**), it is recommended to run implementation in a FRESH CONTEXT for best results.
Expand Down