-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Add inline profile camera capture #6680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
klopez4212
wants to merge
20
commits into
kennylopez-mobile-profile-settings
Choose a base branch
from
kennylopez-mobile-camera-capture
base: kennylopez-mobile-profile-settings
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
4fc3955
feat(mobile): add inline profile photo capture
klopez4212 dbb4bab
fix(mobile): refine profile camera motion
klopez4212 6295fef
fix(mobile): polish profile camera capture motion
klopez4212 2594add
fix(mobile): smooth camera state handoffs
klopez4212 5f663a8
fix(mobile): stabilize emoji editor layout
klopez4212 5a59509
fix(mobile): refine profile camera controls
klopez4212 9ea6ada
fix(mobile): polish avatar capture feedback
klopez4212 c4b1373
fix(mobile): crossfade camera exit controls
klopez4212 8c44b1c
fix(mobile): complete camera exit handoff
klopez4212 be11508
fix(mobile): synchronize camera preview expansion
klopez4212 1cfd1c8
fix(mobile): scale avatar through camera handoff
klopez4212 4de4751
refactor(mobile): keep avatar capture within size limit
klopez4212 eb92b3d
fix(mobile): resize profile camera shutter
klopez4212 82b5943
fix(mobile): enlarge profile camera shutter
klopez4212 287186c
feat(mobile): animate profile camera flips
klopez4212 6d29b94
fix(mobile): polish profile camera selection
klopez4212 0b4c15a
fix(mobile): lock profile capture to portrait
klopez4212 ff3cdab
fix(mobile): preserve animated avatar save handoff
klopez4212 9a6554d
fix(mobile): hide capture placeholder during processing
klopez4212 5728239
fix(mobile): save latest animated avatar framing
klopez4212 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When users rotate the device anywhere outside the profile editor, this activity-level setting now forces every Android screen to remain portrait; the corresponding
Info.plistchange also removes both previously supported landscape orientations on iOS. The camera controllers already lock their capture orientation, so any required UI-orientation lock should be applied only while a profile capture widget is mounted and restored afterward rather than changing the orientation contract for channels, forums, media viewing, and the rest of the app.Useful? React with 👍 / 👎.