Skip to content

Add inline profile camera capture - #6680

Open
klopez4212 wants to merge 12 commits into
kennylopez-mobile-profile-settingsfrom
kennylopez-mobile-camera-capture
Open

Add inline profile camera capture#6680
klopez4212 wants to merge 12 commits into
kennylopez-mobile-profile-settingsfrom
kennylopez-mobile-camera-capture

Conversation

@klopez4212

@klopez4212 klopez4212 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add inline profile photo capture with smooth avatar-to-viewfinder transitions
  • add close, flip, shutter, retry, and use-photo states with haptics and front-camera mirroring
  • polish iOS liquid-glass controls and avatar editor motion

Related issue

Follow-up to #6583.

Testing

  • just mobile-check
  • just mobile-test (1,743 tests)
  • built, installed, and launched on Pixel 10 and iPhone Air

Signed-off-by: kenny lopez <klopez4212@gmail.com>
Signed-off-by: kenny lopez <klopez4212@gmail.com>
Signed-off-by: kenny lopez <klopez4212@gmail.com>
Signed-off-by: kenny lopez <klopez4212@gmail.com>
Signed-off-by: kenny lopez <klopez4212@gmail.com>
Signed-off-by: kenny lopez <klopez4212@gmail.com>
Signed-off-by: kenny lopez <klopez4212@gmail.com>
Signed-off-by: kenny lopez <klopez4212@gmail.com>
Signed-off-by: kenny lopez <klopez4212@gmail.com>
Signed-off-by: kenny lopez <klopez4212@gmail.com>
Signed-off-by: kenny lopez <klopez4212@gmail.com>
Signed-off-by: kenny lopez <klopez4212@gmail.com>
@klopez4212 klopez4212 changed the title Kennylopez mobile camera capture Add inline profile camera capture Aug 24, 2026
@klopez4212
klopez4212 changed the base branch from main to kennylopez-mobile-profile-settings August 24, 2026 09:39
@klopez4212
klopez4212 marked this pull request as ready for review August 24, 2026 09:40
@klopez4212
klopez4212 requested a review from a team as a code owner August 24, 2026 09:40

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4de4751edd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +100 to +101
const SizedBox(height: avatarEditorOptionLabelGap),
labelWidget(),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Exclude iOS rail captions from accessibility semantics

On iOS, the native glass button already exposes label as its accessibility label, while the adjacent labelWidget() remains a separate Flutter semantics node. VoiceOver therefore stops twice on every Image, Emoji, and Animated rail option—once for the actionable button and again for the identical static caption. Exclude the visible caption from semantics, as the non-iOS branch already does for its descendants.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant