Skip to content

Conversation

1440000bytes
Copy link

@1440000bytes 1440000bytes commented Oct 15, 2025

Rationale:

  • It will help users to know about extra pool transactions
  • Developers can use it while testing compact block relay
image

Copy link

@kwsantiago kwsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation is functional but has performance and documentation issues. The most critical gap is the lack of test coverage. The counting function's O(n) complexity could impact performance when the extra pool is large (default 32,768 txs).

const NodeContext& node = EnsureAnyNodeContext(request.context);
PeerManager& peerman = EnsurePeerman(node);

LOCK(::cs_main);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding cs_main lock while calling the potentially slow count function could block other threads unnecessarily.

@1440000bytes
Copy link
Author

1440000bytes commented Oct 17, 2025

Thanks for the review! I’ve addressed some of the comments and will work on improving the code further.

@1440000bytes 1440000bytes changed the title Add getextrapoolinfo RPC rpc: Add getextrapoolinfo RPC Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants