p2p: remove confirmed transactions from extra pool #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-jr
reviewed
Oct 20, 2025
| if (extra_tx && block_tx_hashes.count(extra_tx->GetHash())) { | ||
| blockreconstructionextratxn_memusage -= RecursiveDynamicUsage(*extra_tx); | ||
| vExtraTxnForCompactCount--; | ||
| extra_tx.reset(); |
There was a problem hiding this comment.
This frees memory, but doesn't change the fact that the circular buffer will still replace other transactions before filling the "holes" left by this
There was a problem hiding this comment.
Do you think its an improvement over status quo or not necessary?
kwsantiago
reviewed
Oct 20, 2025
1440000bytes
force-pushed
the
remove-minedtxs-extrapool
branch
from
5a5fcb5 to
80a86ee
Compare
|
Rebased on top of #221 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale:
TODO: Add functional test