Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bulk_scan barcode #512
base: master-overhaul
Are you sure you want to change the base?
bulk_scan barcode #512
Changes from 13 commits
b88cb47
55112b4
8581e56
5246840
426c52d
9e5d731
798f316
6e893fe
ce8aeb3
6595d56
4da556e
70b4848
7190611
1a41df8
831cb4e
573eb45
4995448
6e1d424
f7d26bf
a7e58c8
fb6de2e
fc8d160
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mapping between samples and racks needs to be sensitive to the fact that samples can move from rack to rack. Right now, the code just assumes that there's a stable relationship, which results in issues when you test using different sample barcodes with the same rack ID. Retrieving the samples from a rack should only reflect the samples that were present at the most recent scan, not every sample that has ever been on the rack.
Also, please pluralize the function name to reflect that we expect multiple samples to exist on a rack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved the issue!