-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bulk_scan barcode #512
base: master-overhaul
Are you sure you want to change the base?
bulk_scan barcode #512
Conversation
Master overhaul merge to my fork
return response | ||
|
||
|
||
def get_sample_from_rack(token_info, rack_id): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mapping between samples and racks needs to be sensitive to the fact that samples can move from rack to rack. Right now, the code just assumes that there's a stable relationship, which results in issues when you test using different sample barcodes with the same rack ID. Retrieving the samples from a rack should only reflect the samples that were present at the most recent scan, not every sample that has ever been on the rack.
Also, please pluralize the function name to reflect that we expect multiple samples to exist on a rack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved the issue!
@raginirai553 We just merged a big set of changes into master-overhaul. Can you please back-out the changes to |
No description provided.