[Types] Inline LuaCATS busted+luassert type annotations#7438
Open
keithharvey wants to merge 1 commit into
Open
[Types] Inline LuaCATS busted+luassert type annotations#7438keithharvey wants to merge 1 commit into
keithharvey wants to merge 1 commit into
Conversation
Contributor
Integration Test Results14 tests 6 ✅ 3s ⏱️ Results for commit 0714c7b. ♻️ This comment has been updated with latest results. |
This was referenced Apr 14, 2026
Draft
b923614 to
e39598c
Compare
8 tasks
32f8dca to
8dc58ed
Compare
99717a3 to
835780b
Compare
9f82944 to
4f8cb32
Compare
4f8cb32 to
181f662
Compare
181f662 to
38ba564
Compare
38ba564 to
8f59684
Compare
fe392a8 to
ac786a2
Compare
ac786a2 to
4ebf393
Compare
4ebf393 to
b4e7c10
Compare
b4e7c10 to
a0c7634
Compare
a0c7634 to
878756e
Compare
878756e to
f3590d0
Compare
f3590d0 to
81ecd76
Compare
81ecd76 to
c178461
Compare
c178461 to
e154397
Compare
e154397 to
24f02ee
Compare
24f02ee to
f0ac916
Compare
f0ac916 to
16d080f
Compare
16d080f to
c1f8c03
Compare
Vendored LuaCATS annotations for busted/luassert to provide IntelliSense for the unit-test surface. Lives on its own leaf so the discussion around 'vendoring LuaCATS types' can happen in isolation — prior pushback on the same direction in an earlier unit-testing PR makes this the right place to litigate it rather than burying it in a broader env commit. Why vendored instead of declared as a Lux dep: Lux does not yet support pulling LuaCATS annotations from library deps, and quick attempts to wire this up in Lux failed. Upstream tracking issue: lumen-oss/lux#953 — once that lands, these directories should be deleted in favor of declaring busted as a normal Lux dev-dep. Sources (pinned SHAs): - types/busted/ https://github.com/LuaCATS/busted @ 5ed85d0e016a5eb5eca097aa52905eedf1b180f1 - types/luassert/ https://github.com/LuaCATS/luassert @ d3528bb679302cbfdedefabb37064515ab95f7b9 See types/busted/provenance.md and types/luassert/provenance.md for per-directory upstream refs + license status.
c1f8c03 to
0714c7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of BAR type-error cleanup. Rebuilds idempotently from
masterviajust bar::fmt-mig-generate.What it does: Hand-curated (not a codemod): vendors LuaCATS/busted and LuaCATS/luassert type annotations under
types/busted/andtypes/luassert/.Waits on lumen-oss/lux#953 to replace with a Lux dev-dep declaration.
Branch Topology
All branches in the BAR type-error cleanup stack. Regenerated deterministically by
just bar::fmt-mig-generate. Generated 2026-06-11 10:24:57 UTC.Leaves — each targets
master, mergeable independently:styluabar-lua-codemod bracket-to-dotbar-lua-codemod rename-aliasesbar-lua-codemod detach-bar-modulesbar-lua-codemod i18n-kikitobar-lua-codemod spring-split<hand curated><hand curated>Rollups — composite branches stacking the leaves and (for
fmt-llm) the env + LLM layers:master