[Types] detach-bar-modules

[keithharvey]

Part of BAR type-error cleanup. Rebuilds idempotently from master via just bar::fmt-mig-generate.

What it does: Moves BAR-added helpers off the Spring table into a BAR namespace — Spring.I18N → BAR.I18N, plus BAR.Utilities, BAR.Debug, BAR.Lava, and BAR.GetModOptionsCopy — since they aren't engine API and otherwise break type-checking against the Spring stubs.

# detach-bar-modules -- moves I18N, Utilities, Debug, Lava, GetModOptionsCopy off the Spring table
bar-lua-codemod detach-bar-modules --path "$BAR_DIR" --exclude common/luaUtilities

The detach-bar-modules-env prereq exposes BAR to the widget/gadget sandbox (luarules/system.lua, luaui/system.lua), bootstraps BAR = BAR or {} in init.lua/springOverrides.lua before the detached defs, adds the consolidated types/BAR.lua stub, and lists BAR as a global in .emmyrc.json. Cherry-picked on top of fmt before the codemod runs.

Branch Topology

All branches in the BAR type-error cleanup stack. Regenerated deterministically by just bar::fmt-mig-generate. Generated 2026-07-17 07:18:45 UTC.

Leaves — each targets master, mergeable independently:

Branch	Command	Diff vs parent	Units
fmt	stylua	1376 files, +179088 −184017	✅ pass
mig-bracket	bar-lua-codemod bracket-to-dot	338 files, +7645 −7645	✅ pass
mig-rename-aliases	bar-lua-codemod rename-aliases	175 files, +377 −377	✅ pass
mig-detach-bar-modules ← you are here	bar-lua-codemod detach-bar-modules	178 files, +1694 −1565	✅ pass
mig-integration-tests	<hand curated>	20 files, +134 −81	✅ pass
mig-busted-types	<hand curated>	12 files, +1501 −0	✅ pass

Rollups — composite branches stacking the leaves and (for fmt-llm) the env + LLM layers:

Branch	What it is	Diff vs master	Diff vs parent	Units
mig	all deterministic transforms combined; rebuilds from master	1400 files, +183338 −186584	512 files, +11305 −9622	✅ pass
fmt-llm-source	human-curated env layer (.emmyrc.json, types/* stubs, CI gate) + manual fixes that drive type errors to 0 in concert with the LLM pass	1405 files, +183806 −186746	61 files, +522 −216	✅ pass
fmt-llm	fmt-llm-source + one LLM type-triage commit — the mergeable tip	1406 files, +183857 −186765	30 files, +66 −34	✅ pass

[github-actions]

Integration Test Results

14 tests   6 ✅  3s ⏱️
 1 suites  8 💤
 1 files    0 ❌

Results for commit f29ff49.

♻️ This comment has been updated with latest results.

[sprunk]

why?

[keithharvey]

why?

Short answer: they aren't engine API, and having them on Spring is misleading.

This came directly out of working on spring-split. When you split Spring into SpringSynced / SpringUnsynced / SpringShared based on the engine's actual type definitions, these five modules (I18N, Utilities, Debug, Lava, GetModOptionsCopy) show up as ~1,700 unmapped orphans — because they were never engine methods in the first place. They're BAR's own modules, monkey-patched onto Spring as a namespace convenience.

Detaching them makes the split cleaner: SpringX tables contain engine API, and game-level modules live under their own names. It also means we can type them properly in the library definitions without awkwardly extending or inheriting from SpringShared for things that have nothing to do with the engine.

Totally open to other ideas, this just seemed accurate to me if I was trying for "pure" types for the engine API.

[efrec]

I don't dislike separating code not sourced from the engine like this.

But I kind of do dislike a top-level "Utilities".