Skip to content

Query::for_each_combinations(_mut) #4704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
james7132 opened this issue May 9, 2022 · 2 comments
Open

Query::for_each_combinations(_mut) #4704

james7132 opened this issue May 9, 2022 · 2 comments
Labels
A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible

Comments

@james7132
Copy link
Member

What problem does this solve or what need does it fill?

Query::for_each_combinations(_mut), the for_each equivalent of iter_combinations(_mut).

What solution would you like?

The bug that is cited in the docs for Query::iter_combinations (rust-lang/rust#62529), has been resolved. Another attempt at implementing it should be taken.

What alternative(s) have you considered?

Don't implement it. Remove the comment about the bug.

@james7132 james7132 added C-Feature A new feature, making something new possible A-ECS Entities, components, systems, and events labels May 9, 2022
@campbellcole
Copy link

campbellcole commented Aug 20, 2022

I second this, especially since it seems iter_combinations is essentially O(n^2) and could probably benefit the most from par_for_each(_mut)

@tim-blackbird
Copy link
Contributor

@campbellcole This issue is about for_each not par_for_each.
Not familiar enough to know how hard par_for_each would be to implement, but par_for_each_mut is not possible for combinations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants