Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose bevy_math::curve::easing::easing_functions to public #17665

Closed
vveisard opened this issue Feb 3, 2025 · 2 comments
Closed

Expose bevy_math::curve::easing::easing_functions to public #17665

vveisard opened this issue Feb 3, 2025 · 2 comments
Labels
A-Animation Make things move and change over time A-Math Fundamental domain-agnostic mathematical operations C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@vveisard
Copy link

vveisard commented Feb 3, 2025

What problem does this solve or what need does it fill?

I want to use easing functions directly.

What solution would you like?

I would like bevy_math::curve::easing::easing_functions to have public visibility.

What alternative(s) have you considered?

I can use the simple_easing crate.

Additional context

There isn't a reason for these not to be publicly visible.
@vveisard vveisard added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Feb 3, 2025
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Animation Make things move and change over time A-Math Fundamental domain-agnostic mathematical operations S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! and removed C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Feb 3, 2025
@alice-i-cecile
Copy link
Member

I'd welcome a quick PR for this. simple_easing has a number of long-standing bugs, so I'm happy to provide our implementation to the public.

@fjkorf fjkorf mentioned this issue Feb 6, 2025
Closed
@alice-i-cecile
Copy link
Member

PR that did this was rejected; I think a stronger case is needed to reopen this issue.

@alice-i-cecile alice-i-cecile closed this as not planned Won't fix, can't repro, duplicate, stale Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Animation Make things move and change over time A-Math Fundamental domain-agnostic mathematical operations C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Public easing fjkorf/bevy
2 participants
@alice-i-cecile @vveisard