Fix clippy

Author: MrGVSV

crates/bevy_reflect/src/serde/de.rs

@@ -87,7 +87,7 @@ impl<'a, 'de> Visitor<'de> for ReflectDeserializerVisitor<'a> {
 
         match map.next_key::<&str>()? {
             Some(type_fields::VALUE) => {
-                let registration = self.registry.get_with_name(&type_name).ok_or_else(|| {
+                let registration = self.registry.get_with_name(type_name).ok_or_else(|| {
                     de::Error::custom(format_args!("No registration found for {}", type_name))
                 })?;
                 let type_info = registration.type_info();
@@ -99,12 +99,10 @@ impl<'a, 'de> Visitor<'de> for ReflectDeserializerVisitor<'a> {
             }
             Some(type_fields::TYPE) => Err(de::Error::duplicate_field(type_fields::TYPE)),
             Some(field) => Err(de::Error::unknown_field(field, &[type_fields::VALUE])),
-            None => {
-                return Err(de::Error::invalid_length(
-                    0,
-                    &"two entries: `type` and `value`",
-                ));
-            }
+            None => Err(de::Error::invalid_length(
+                0,
+                &"two entries: `type` and `value`",
+            )),
         }
     }
 }
@@ -462,6 +460,7 @@ mod tests {
     use bevy_utils::HashMap;
     use serde::de::DeserializeSeed;
     use serde::Deserialize;
+    use std::f32::consts::PI;
 
     #[derive(Reflect, FromReflect, Debug, PartialEq)]
     struct MyStruct {
@@ -526,7 +525,7 @@ mod tests {
         let expected = MyStruct {
             primitive_value: 123,
             option_value: Some(String::from("Hello world!")),
-            tuple_value: (3.14, 1337),
+            tuple_value: (PI, 1337),
             list_value: vec![-2, -1, 0, 1, 2],
             array_value: [-2, -1, 0, 1, 2],
             map_value: map,
@@ -544,7 +543,7 @@ mod tests {
                 "primitive_value": 123,
                 "option_value": Some("Hello world!"),
                 "tuple_value": (
-                    3.14,
+                    3.1415927,
                     1337,
                 ),
                 "list_value": [

crates/bevy_reflect/src/serde/ser.rs

@@ -260,6 +260,7 @@ mod tests {
     use crate::{Reflect, TypeRegistry};
     use bevy_utils::HashMap;
     use serde::Serialize;
+    use std::f32::consts::PI;
 
     #[derive(Reflect, Debug, PartialEq)]
     struct MyStruct {
@@ -311,7 +312,7 @@ mod tests {
         let input = MyStruct {
             primitive_value: 123,
             option_value: Some(String::from("Hello world!")),
-            tuple_value: (3.14, 1337),
+            tuple_value: (PI, 1337),
             list_value: vec![-2, -1, 0, 1, 2],
             array_value: [-2, -1, 0, 1, 2],
             map_value: map,
@@ -332,7 +333,7 @@ mod tests {
     "value": {
         "primitive_value": 123,
         "option_value": Some("Hello world!"),
-        "tuple_value": (3.14, 1337),
+        "tuple_value": (3.1415927, 1337),
         "list_value": [
             -2,
             -1,