Skip to content

Commit 90433d1

Browse files
committed
Apply review comment
1 parent b35f7a3 commit 90433d1

File tree

1 file changed

+4
-4
lines changed
  • crates/bevy_reflect/src/serde

1 file changed

+4
-4
lines changed

crates/bevy_reflect/src/serde/de.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -138,10 +138,10 @@ impl<'a, 'de> Visitor<'de> for UntypedReflectDeserializerVisitor<'a> {
138138
A: MapAccess<'de>,
139139
{
140140
let type_name = map
141-
.next_key::<&str>()?
141+
.next_key::<String>()?
142142
.ok_or_else(|| Error::invalid_length(0, &"at least one entry"))?;
143143

144-
let registration = self.registry.get_with_name(type_name).ok_or_else(|| {
144+
let registration = self.registry.get_with_name(&type_name).ok_or_else(|| {
145145
Error::custom(format_args!("No registration found for {}", type_name))
146146
})?;
147147
let type_info = registration.type_info();
@@ -512,12 +512,12 @@ impl<'a, 'de> Visitor<'de> for EnumVisitor<'a> {
512512
V: MapAccess<'de>,
513513
{
514514
let variant_name = map
515-
.next_key::<&str>()?
515+
.next_key::<String>()?
516516
.ok_or_else(|| Error::missing_field("the variant name of the enum"))?;
517517

518518
let variant_info = self
519519
.enum_info
520-
.variant(variant_name)
520+
.variant(&variant_name)
521521
.ok_or_else(|| Error::custom(format_args!("unknown variant {}", variant_name)))?;
522522

523523
let mut dynamic_enum = DynamicEnum::default();

0 commit comments

Comments
 (0)