Skip to content

fix(ring): add hover_progress Qt property validation for QPropertyAnimation target #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 5 commits into from
Closed

fix(ring): add hover_progress Qt property validation for QPropertyAnimation target #1101

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
177b2a4
fix(ring_progress_bar): added hover mouse effect
wyzula-jan Jan 28, 2026
2c14038
fix(ring): minor general fixes
wyzula-jan Jan 28, 2026
ba1eece
Initial plan
Copilot Mar 17, 2026
13f423d
Merge branch 'feat/ring-progress-enhanced' into copilot/sub-pr-1031
wyzula-jan Mar 17, 2026
7f9c8ad
fix(ring): verify hover_progress Qt property is registered before ani…
Copilot Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion bec_widgets/widgets/progress/ring_progress_bar/ring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,21 @@ def __init__(self, parent: RingProgressContainerWidget | None = None, client=Non
self._gap = 5
self._hovered = False
self._hover_progress = 0.0
# NOTE: b"hover_progress" must match the @SafeProperty(float) named 'hover_progress'
# defined on this class. QPropertyAnimation silently fails if the target property is
# absent or misnamed, so we verify registration immediately after construction.
self._hover_animation = QtCore.QPropertyAnimation(self, b"hover_progress", parent=self)
if self.metaObject().indexOfProperty("hover_progress") == -1: # pragma: no cover
logger.warning(
"Ring: 'hover_progress' is not registered as a Qt property; "
"the hover animation will not work. Ensure the 'hover_progress' "
"SafeProperty is defined on this class."
)
self._hover_animation.setDuration(180)
easing_curve = (
QtCore.QEasingCurve.Type.OutCubic
if hasattr(QtCore.QEasingCurve, "Type")
else QtCore.QEasingCurve.Type.OutCubic
else QtCore.QEasingCurve.OutCubic
)
self._hover_animation.setEasingCurve(easing_curve)
self.set_start_angle(self.config.start_position)
Expand Down
Loading