fix(ring): add hover_progress Qt property validation for QPropertyAnimation target#1101
Closed
Copilot wants to merge 5 commits intofeat/ring-progress-enhancedfrom
Closed
fix(ring): add hover_progress Qt property validation for QPropertyAnimation target#1101Copilot wants to merge 5 commits intofeat/ring-progress-enhancedfrom
Copilot wants to merge 5 commits intofeat/ring-progress-enhancedfrom
Conversation
2c14038 to
f1a0c02
Compare
…mation use Co-authored-by: wyzula-jan <133381102+wyzula-jan@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. |
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on hover mouse effect for ring_progress_bar
fix(ring): add hover_progress Qt property validation for QPropertyAnimation target
Mar 17, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QPropertyAnimation(self, b"hover_progress")silently does nothing if the target Qt property is absent or misnamed — no exception, no log, no visual feedback. This PR adds an explicit guard and documents the dependency.Description
# NOTE:comment above theQPropertyAnimationconstructor documenting thatb"hover_progress"must match the@SafeProperty(float)namedhover_progressdefined on the class.metaObject().indexOfProperty("hover_progress") == -1check immediately after construction that emits alogger.warningif the property isn't registered in Qt's meta-object system.elsebranch incorrectly usedQtCore.QEasingCurve.Type.OutCubic(would raiseAttributeErroron older Qt without.Type), corrected toQtCore.QEasingCurve.OutCubic.Related Issues
Type of Change
How to test
Ring/RingProgressBarin designer and verify hover animation still works as expectedPotential side effects
None. The check is read-only and the warning path is marked
# pragma: no cover(only reachable if the property is removed).Screenshots / GIFs (if applicable)
Additional Comments
Original PR: #1031. Addresses review feedback on the
hover_progressanimation target dependency.Definition of Done
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.