Skip to content

refactor/fix: stream subscriptions in RedisConnector #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d-perl wants to merge 3 commits into
base: main
Choose a base branch
from
+334 −212
Open

refactor/fix: stream subscriptions in RedisConnector #795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
866015e
refactor: stream subs in redisconnector
d-perl Mar 13, 2026
4810781
fix: add public method to check existing subs
d-perl Mar 16, 2026
9088cc1
fix: _on_new_scope_change_msg not static
d-perl Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bec_ipython_client/tests/end-2-end/test_scans_e2e.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def test_mv_scan_nested_device(capsys, bec_ipython_client_fixture):
bec.metadata.update({"unit_test": "test_mv_scan_nested_device"})
dev = bec.device_manager.devices
scans.mv(dev.hexapod.x, 10, dev.hexapod.y, 20, relative=False).wait()
if not bec.connector._messages_queue.empty():
if not bec.connector._message_callbacks_queue.empty():
print("Waiting for messages to be processed")
time.sleep(0.5)
current_pos_hexapod_x = dev.hexapod.x.read(cached=True)["hexapod_x"]["value"]
Expand All @@ -126,7 +126,7 @@ def test_mv_scan_nested_device(capsys, bec_ipython_client_fixture):
current_pos_hexapod_y, 20, atol=dev.hexapod._config["deviceConfig"].get("tolerance", 0.5)
)
scans.umv(dev.hexapod.x, 10, dev.hexapod.y, 20, relative=False)
if not bec.connector._messages_queue.empty():
if not bec.connector._message_callbacks_queue.empty():
print("Waiting for messages to be processed")
time.sleep(0.5)
current_pos_hexapod_x = dev.hexapod.x.read(cached=True)["hexapod_x"]["value"]
Expand Down
5 changes: 3 additions & 2 deletions bec_lib/bec_lib/messaging_services.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,10 @@ def set_default_scope(self, scope: str | list[str] | None) -> None:
raise ValueError(f"Scope '{scope}' is not available for this messaging service.")
self._default_scope = scope

@staticmethod
def _on_new_scope_change_msg(
message: dict[str, messages.AvailableMessagingServicesMessage], parent: MessagingService
self,
message: dict[str, messages.AvailableMessagingServicesMessage],
parent: MessagingService,
) -> None:
"""
Callback for scope changes. Currently a placeholder for future functionality.
Expand Down
Loading
Loading