refactor/fix: stream subscriptions in RedisConnector#795
Open
refactor/fix: stream subscriptions in RedisConnector#795
Conversation
2cd3083 to
758f4d2
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
3dacf1e to
fcc6b6c
Compare
- clearer organisation: class to handle subscription tasks - more correct: no multiple subscriptions, test logic
fcc6b6c to
338943e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the Redis stream subscription logic in the RedisConnector
from_startstreams after the first tryLooks like some small patch in BEC widgets will be required where duplicate subs were previously ignored - workflow against BW branch https://github.com/bec-project/bec/actions/runs/23142709927
closes #790