feat: permit construction of entry reader#162
Merged
Conversation
CosmicHorrorDev
approved these changes
May 9, 2026
Collaborator
CosmicHorrorDev
left a comment
CosmicHorrorDev
left a comment
There was a problem hiding this comment.
just a couple of small tweaks, but otherwise looks good!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
==========================================
+ Coverage 77.97% 78.00% +0.02%
==========================================
Files 27 27
Lines 2711 2714 +3
Branches 134 134
==========================================
+ Hits 2114 2117 +3
Misses 528 528
Partials 69 69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
blerg i swear i had rebase selected, but github did a merge commit still. feel free to rebase that away |
sftse
force-pushed
the
control-entry-reader
branch
from
521efb6 to
501128e
Compare
sftse
force-pushed
the
control-entry-reader
branch
from
501128e to
7e00b2b
Compare
Collaborator
|
well looks like i got removed as a collaborator, so things are all up to @fasterthanlime now 🫡 |
Collaborator
|
we're so back! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, we want more fine-grained control over when we borrow from the underlying reader.
An alternative would be to expose
EntryReader::newbut I can't see how that level of control would be useful, we always want to use it in the natural way withfn cursor_at.