WIP: less generic API#163
Draft
sftse wants to merge 3 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
==========================================
- Coverage 77.97% 77.50% -0.48%
==========================================
Files 27 27
Lines 2711 2689 -22
Branches 134 134
==========================================
- Hits 2114 2084 -30
- Misses 528 536 +8
Partials 69 69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if this fact is known, but if we lean further into the concrete entry reader of #162 we get a much less generic API.
I think this makes the API simpler and more orthogonal with other features of Rust because the reader can still be attached with common iterator methods:
The old API for iterating over entries for example can be expressed as
The only downsides I can think of is that in the common case, for example reading from
Filethere is a chance that a user misconstrues the reader on anotherFile, as it's not passed down internally. Such a mistake would appear to be reasonably easy to find.Feel free to close if not interested.
Would be an alternative to #157