Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSTEAM1-1634: Adds superResponsive to media player config #12365

Merged
merged 5 commits into from
Feb 7, 2025
Merged

WSTEAM1-1634: Adds superResponsive to media player config #12365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fa348b0
WSTEAM1-1588: Adds superresponsive
Isabella-Mitchell Feb 5, 2025
cf0d95d
WSTEAM1-1588: Update unit tests:
Isabella-Mitchell Feb 5, 2025
8915d2c
Merge branch 'latest' into WSTEAM1-1588-media-player-no-css
Isabella-Mitchell Feb 5, 2025
12f932d
WSTEAM1-1588: Limits superResponsive to non-embedded meida
Isabella-Mitchell Feb 7, 2025
fadd821
Merge branch 'latest' into WSTEAM1-1588-media-player-no-css
Isabella-Mitchell Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/app/components/MediaLoader/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ export type PlayerConfig = {
insideIframe?: boolean;
embeddedOffsite?: boolean;
externalEmbedUrl?: string;
superResponsive?: boolean;
statsObject: {
clipPID?: string | null;
episodePID?: string | null;
Expand Down
10 changes: 10 additions & 0 deletions src/app/components/MediaLoader/utils/buildSettings.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ describe('buildSettings', () => {
appName: 'news-serbian',
appType: 'responsive',
counterName: 'live_coverage.testID.page',
superResponsive: true,
playlistObject: {
title:
"BBC launch trailer for We Know Our Place women's sport campaign",
Expand Down Expand Up @@ -158,6 +159,7 @@ describe('buildSettings', () => {
appName: 'news-serbian',
appType: 'responsive',
counterName: 'live_coverage.testID.page',
superResponsive: true,
playlistObject: {
title: 'Five things ants can teach us about management',
summary: 'This is a caption!',
Expand Down Expand Up @@ -224,6 +226,7 @@ describe('buildSettings', () => {
appName: 'news-serbian',
appType: 'responsive',
counterName: 'live_coverage.testID.page',
superResponsive: true,
playlistObject: {
title: 'Five things ants can teach us about management',
summary: 'This is a caption!',
Expand Down Expand Up @@ -292,6 +295,7 @@ describe('buildSettings', () => {
appName: 'news-serbian',
appType: 'responsive',
counterName: 'live_coverage.testID.page',
superResponsive: true,
externalEmbedUrl:
'https://www.bbc.com/serbian/lat/av-embeds/srbija-68707945/vpid/bbc_arabic_tv',
playlistObject: {
Expand Down Expand Up @@ -349,6 +353,7 @@ describe('buildSettings', () => {
appName: 'news-arabic',
appType: 'responsive',
counterName: 'arabic.multimedia.2013.12.131208_iraq_blast_.page',
superResponsive: true,
playlistObject: {
title: 'Legacy Media Page Title',
holdingImageURL:
Expand Down Expand Up @@ -700,6 +705,7 @@ describe('buildSettings', () => {
autoplay: false,
appName: 'news-hindi',
counterName: 'hindi.bbc_hindi_tv.tv.w172zm8920nck2z.page',
superResponsive: true,
statsObject: {
destination: 'WS_NEWS_LANGUAGES',
producer: 'HINDI',
Expand Down Expand Up @@ -874,6 +880,7 @@ describe('buildSettings', () => {
appType: 'responsive',
autoplay: false,
counterName: 'hausa.bbc_hausa_radio.liveradio.page',
superResponsive: true,
playlistObject: {
items: [
{
Expand Down Expand Up @@ -956,6 +963,7 @@ describe('buildSettings', () => {
autoplay: false,
appName: 'news-afrique',
counterName: 'afrique.bbc_afrique_radio.w172zn0kxd65h3g.page',
superResponsive: true,
statsObject: {
destination: 'WS_NEWS_LANGUAGES',
producer: 'AFRIQUE',
Expand Down Expand Up @@ -1081,6 +1089,7 @@ describe('buildSettings', () => {
autoplay: false,
counterName: 'live_coverage.c7dkx155e626t.page',
enableToucan: true,
superResponsive: true,
playlistObject: {
holdingImageURL:
'https://ichef.bbci.co.uk/images/ic/$recipe/p0k31t4d.jpg',
Expand Down Expand Up @@ -1180,6 +1189,7 @@ describe('buildSettings', () => {
autoplay: false,
counterName: 'live_coverage.cvp5r6m6mgpt.page',
enableToucan: true,
superResponsive: true,
playlistObject: {
holdingImageURL:
'https://ichef.bbci.co.uk/images/ic/$recipe/p08b23t4.png',
Expand Down
1 change: 1 addition & 0 deletions src/app/components/MediaLoader/utils/buildSettings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ const buildSettings = ({
subtitles: { enabled: true, defaultOn: true },
fullscreen: { enabled: true },
},
...(!embedded && { superResponsive: true }),
...(counterName && { counterName }),
...(isTestRequested() && { mediator: { host: 'open.test.bbc.co.uk' } }),
statsObject: {
Expand Down
Loading