-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WSTEAM1-1634: Adds superResponsive to media player config #12365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
Looks good. Worth testing |
Good idea - is this a valid asset to test? - https://www.bbc.co.uk/news/articles/c9qjdex1ed8o.amp. |
Yea would be good to test on the page as well as direct via something like: http://localhost:7081/ws/av-embeds/articles/cd1rmn075d1o/p0jd37n8/ig?renderer_env=live |
Thanks for resolving via Slack. I have limited the superResponsive setting to non-embedded media |
Resolves JIRA WSTEAM1-1634
Overall changes
Adds superResponsive to media player to config. This fixes an issue on no-CSS bug where the video player is not visible after the placeholder is clicked.
Note, this doesn't fix the same issue with audio players.
More in dropbox paper. Not the bug I set out to solve - but it's a bug non the less.
Bug on live (media player is not visible after placeholder is clicked)
![Screenshot 2025-02-05 at 14 31 55](https://private-user-images.githubusercontent.com/98817636/410035670-32f43cb4-4517-46f3-8fa8-c21488cc30c2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNjE2NTYsIm5iZiI6MTczOTE2MTM1NiwicGF0aCI6Ii85ODgxNzYzNi80MTAwMzU2NzAtMzJmNDNjYjQtNDUxNy00NmYzLThmYTgtYzIxNDg4Y2MzMGMyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDA0MjIzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI1MTQ5YWNmZDQ4OGVkMmU2Yzc4Y2YzNWQzZWIzZWE1MThhMjJmM2U4YmRiYWY5OWZlNWZhNDQ1ODcxZjhmNjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.WD3HxRcvz4At678uX7LobfW2aodqeMHmdnCVwhviAlM)
This PR:
![Screenshot 2025-02-05 at 14 31 20](https://private-user-images.githubusercontent.com/98817636/410035712-10e79b51-2152-47fc-bfed-4f887f0487ed.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNjE2NTYsIm5iZiI6MTczOTE2MTM1NiwicGF0aCI6Ii85ODgxNzYzNi80MTAwMzU3MTItMTBlNzliNTEtMjE1Mi00N2ZjLWJmZWQtNGY4ODdmMDQ4N2VkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDA0MjIzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZiN2FmMDg1MTEyMmM4MDM3OTBlODdmMTIwYzIzYzUxMzMzMzAxYzlkMTg2NzBhYjY0NzdlMzU2YjIxMWRhODUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.SlR15VL4enbPpeIIDVq10Vv3JNCNtpioxGouz0Zkdns)
Code changes
Testing
(Video media that uses placeholder)
Article Page (inc. portrait video): http://localhost.bbc.com:7080/mundo/articles/c1xv2q1gewvo?renderer_env=test
Article page (with working videos): http://localhost.bbc.com:7080/persian/articles/ce54jxx243eo?renderer_env=live
Live page (with video in post): http://localhost.bbc.com:7081/arabic/live/cvg8n9xeglgt?renderer_env=live
OD TV (brand): http://localhost.bbc.com:7080/hausa/bbc_hausa_tv/tv_programmes/w13xttn0?renderer_env=live
OD TV (episode): http://localhost.bbc.com:7080/hausa/bbc_hausa_tv/tv/w172yjj83ptptnj?renderer_env=live
To test, visit page, turn off CSS, click placeholder to play video.
Video should play, be visible and can be controlled via controls.
Can compare to current experience on live (media player is not visible after placeholder is clicked).
See ticket for link to testing doc including Regression Testing
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines