Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSTEAM1-1634: Adds superResponsive to media player config #12365

Merged
merged 5 commits into from
Feb 7, 2025

Conversation

Isabella-Mitchell
Copy link
Contributor

@Isabella-Mitchell Isabella-Mitchell commented Feb 5, 2025

Resolves JIRA WSTEAM1-1634

Overall changes

Adds superResponsive to media player to config. This fixes an issue on no-CSS bug where the video player is not visible after the placeholder is clicked.

Note, this doesn't fix the same issue with audio players.

More in dropbox paper. Not the bug I set out to solve - but it's a bug non the less.

Bug on live (media player is not visible after placeholder is clicked)
Screenshot 2025-02-05 at 14 31 55

This PR:
Screenshot 2025-02-05 at 14 31 20

Code changes

  • Adds superResponsive to media player config

Testing

(Video media that uses placeholder)
Article Page (inc. portrait video): http://localhost.bbc.com:7080/mundo/articles/c1xv2q1gewvo?renderer_env=test
Article page (with working videos): http://localhost.bbc.com:7080/persian/articles/ce54jxx243eo?renderer_env=live
Live page (with video in post): http://localhost.bbc.com:7081/arabic/live/cvg8n9xeglgt?renderer_env=live
OD TV (brand): http://localhost.bbc.com:7080/hausa/bbc_hausa_tv/tv_programmes/w13xttn0?renderer_env=live
OD TV (episode): http://localhost.bbc.com:7080/hausa/bbc_hausa_tv/tv/w172yjj83ptptnj?renderer_env=live

To test, visit page, turn off CSS, click placeholder to play video.
Video should play, be visible and can be controlled via controls.
Can compare to current experience on live (media player is not visible after placeholder is clicked).

See ticket for link to testing doc including Regression Testing

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@Isabella-Mitchell Isabella-Mitchell changed the title WSTEAM1-1588: Adds superresponsive WSTEAM1-1588: Adds superResponsive to media player config Feb 5, 2025
@Isabella-Mitchell Isabella-Mitchell marked this pull request as ready for review February 5, 2025 14:47
Copy link
Contributor

@karinathomasbbc karinathomasbbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@amoore108
Copy link
Contributor

Looks good. Worth testing av-embeds as well to make sure that player isn't affected?

@Isabella-Mitchell Isabella-Mitchell changed the title WSTEAM1-1588: Adds superResponsive to media player config WSTEAM1-1634: Adds superResponsive to media player config Feb 5, 2025
@Isabella-Mitchell
Copy link
Contributor Author

Isabella-Mitchell commented Feb 5, 2025

Looks good. Worth testing av-embeds as well to make sure that player isn't affected?

Good idea - is this a valid asset to test? - https://www.bbc.co.uk/news/articles/c9qjdex1ed8o.amp.

@amoore108
Copy link
Contributor

Looks good. Worth testing av-embeds as well to make sure that player isn't affected?

Good idea - is this a valid asset to test? - https://www.bbc.co.uk/news/articles/c9qjdex1ed8o.amp.

Yea would be good to test on the page as well as direct via something like: http://localhost:7081/ws/av-embeds/articles/cd1rmn075d1o/p0jd37n8/ig?renderer_env=live

@Isabella-Mitchell
Copy link
Contributor Author

Looks good. Worth testing av-embeds as well to make sure that player isn't affected?

Good idea - is this a valid asset to test? - https://www.bbc.co.uk/news/articles/c9qjdex1ed8o.amp.

Yea would be good to test on the page as well as direct via something like: http://localhost:7081/ws/av-embeds/articles/cd1rmn075d1o/p0jd37n8/ig?renderer_env=live

Thanks for resolving via Slack. I have limited the superResponsive setting to non-embedded media

@Isabella-Mitchell Isabella-Mitchell merged commit b2fc92c into latest Feb 7, 2025
12 checks passed
@Isabella-Mitchell Isabella-Mitchell deleted the WSTEAM1-1588-media-player-no-css branch February 7, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants