Skip to content

feat: upgrade deploy tool to net8.0 #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion site/content/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ To support IDEs using the AWS .NET Deploy tool the CLI can be launched in server
```json
{
"DeployServer":{
"AlternateCliPath":"C:\\code\\aws-dotnet-deploy\\src\\AWS.Deploy.CLI\\bin\\Release\\net6.0\\AWS.Deploy.CLI.exe",
"AlternateCliPath":"C:\\code\\aws-dotnet-deploy\\src\\AWS.Deploy.CLI\\bin\\Release\\net8.0\\AWS.Deploy.CLI.exe",
"PortRange":{
"Start":10000,
"End":10100
Expand Down
2 changes: 1 addition & 1 deletion site/content/docs/commands/deploy.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Inspects the project and recommends AWS compute that is most suited to the type
Deploying HelloWorld

```
dotnet new web -n HelloWorld -f net6.0
dotnet new web -n HelloWorld -f net8.0
cd HelloWorld
dotnet aws deploy
```
Expand Down
8 changes: 4 additions & 4 deletions site/content/docs/deployment-projects/recipe-file.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ The deploy tool supports a collection of tests that can be run against the .NET
"Condition": {
"PropertyName": "TargetFramework",
"AllowedValues": [
"netcoreapp3.1",
"net6.0"
"net8.0",
"net9.0"
]
}
}
Expand Down Expand Up @@ -103,8 +103,8 @@ Here is an example of a rule that checks if the project is a web project and tar
"Condition": {
"PropertyName": "TargetFramework",
"AllowedValues": [
"netcoreapp3.1",
"net6.0"
"net8.0",
"net9.0"
]
}
}
Expand Down
2 changes: 1 addition & 1 deletion site/content/docs/getting-started/run-tool.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ dotnet-aws ...
#### Step 1: Create the ASP.NET Web application

```
dotnet new web -n HelloWorld -f net6.0
dotnet new web -n HelloWorld -f net8.0
```

#### Step 2: cd to the project folder
Expand Down
2 changes: 1 addition & 1 deletion site/content/troubleshooting-guide/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ For example:
```xml
<Project Sdk="Microsoft.NET.Sdk.Web">
<PropertyGroup>
<TargetFrameworkVersion>net6.0</TargetFrameworkVersion>
<TargetFrameworkVersion>net8.0</TargetFrameworkVersion>
<TargetFramework>$(TargetFrameworkVersion)</TargetFramework>
</PropertyGroup>
</Project>
Expand Down
2 changes: 1 addition & 1 deletion site/content/tutorials/custom-project.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Tasks we will accomplish:
In your command prompt, run the following command to create your app:

```
dotnet new webapp -o Acme.WebApp -f net6.0
dotnet new webapp -o Acme.WebApp -f net8.0
```

### Step 2: Generate a deployment project
Expand Down
2 changes: 1 addition & 1 deletion src/AWS.Deploy.CLI/AWS.Deploy.CLI.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFrameworks>net6.0</TargetFrameworks>
<TargetFramework>net8.0</TargetFramework>
<ToolCommandName>dotnet-aws</ToolCommandName>
<IsPackable>true</IsPackable>
<PackAsTool>true</PackAsTool>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,8 @@ public AwsCredentialsAuthenticationHandler(
IOptionsMonitor<AwsCredentialsAuthenticationSchemeOptions> options,
ILoggerFactory logger,
UrlEncoder encoder,
ISystemClock clock,
IEncryptionProvider encryptionProvider)
: base(options, logger, encoder, clock)
: base(options, logger, encoder)
{
_encryptionProvider = encryptionProvider;
}
Expand Down
2 changes: 1 addition & 1 deletion src/AWS.Deploy.Common/AWS.Deploy.Common.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<LangVersion>Latest</LangVersion>
<AssemblyName>AWS.Deploy.Common</AssemblyName>
<RootNamespace>AWS.Deploy.Common</RootNamespace>
Expand Down
4 changes: 2 additions & 2 deletions src/AWS.Deploy.Orchestration/AWS.Deploy.Orchestration.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<LangVersion>Latest</LangVersion>
<AssemblyName>AWS.Deploy.Orchestration</AssemblyName>
<RootNamespace>AWS.Deploy.Orchestration</RootNamespace>
Expand Down Expand Up @@ -37,7 +37,7 @@
<ProjectReference Include="..\AWS.Deploy.Common\AWS.Deploy.Common.csproj" />
<ProjectReference Include="..\AWS.Deploy.Recipes\AWS.Deploy.Recipes.csproj" />
</ItemGroup>

<ItemGroup>
<None Remove="Properties\DockerFileConfig.json" />
<None Remove="Templates\Dockerfile.template" />
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<Product>AWS .NET deployment tool CDK Utilities</Product>
<Description>Utility code used in CDK recipes used by the AWS .NET deployment tool. This package is not intended for direct usage.</Description>
<PackageId>AWS.Deploy.Recipes.CDK.Common</PackageId>
Expand Down
2 changes: 1 addition & 1 deletion src/AWS.Deploy.Recipes/AWS.Deploy.Recipes.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<AssemblyName>AWS.Deploy.Recipes</AssemblyName>
<RootNamespace>AWS.Deploy.Recipes</RootNamespace>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<RollForward>Major</RollForward>
<Nullable>enable</Nullable>
<AWSProjectType>DeploymentProject</AWSProjectType>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<RollForward>Major</RollForward>
<Nullable>enable</Nullable>
<AWSProjectType>DeploymentProject</AWSProjectType>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<RollForward>Major</RollForward>
<Nullable>enable</Nullable>
<AWSProjectType>DeploymentProject</AWSProjectType>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<RollForward>Major</RollForward>
<Nullable>enable</Nullable>
<AWSProjectType>DeploymentProject</AWSProjectType>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<RollForward>Major</RollForward>
<Nullable>enable</Nullable>
<AWSProjectType>DeploymentProject</AWSProjectType>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ private void ConfigureCloudFrontDistribution(Configuration settings)
{
DefaultBehavior = new BehaviorOptions
{
Origin = new S3Origin(ContentS3Bucket, new S3OriginProps())
Origin = S3BucketOrigin.WithOriginAccessControl(ContentS3Bucket)
},
DefaultRootObject = settings.IndexDocument,
EnableIpv6 = settings.EnableIpv6,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<RollForward>Major</RollForward>
<Nullable>enable</Nullable>
<AWSProjectType>DeploymentProject</AWSProjectType>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<RollForward>Major</RollForward>
<Nullable>enable</Nullable>
<AWSProjectType>DeploymentProject</AWSProjectType>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<RollForward>Major</RollForward>
</PropertyGroup>

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>

<IsPackable>false</IsPackable>
<LangVersion>Latest</LangVersion>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>

<IsPackable>false</IsPackable>
</PropertyGroup>
Expand Down
8 changes: 4 additions & 4 deletions test/AWS.Deploy.CLI.UnitTests/AWS.Deploy.CLI.UnitTests.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<IsPackable>false</IsPackable>
<AssemblyName>AWS.Deploy.CLI.UnitTests</AssemblyName>
<RootNamespace>AWS.Deploy.CLI.UnitTests</RootNamespace>
Expand All @@ -16,7 +16,7 @@
<Content Include="TestFiles\**">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</Content>
</ItemGroup>
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.5.0" />
Expand All @@ -34,7 +34,7 @@
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>

</ItemGroup>

<ItemGroup>
Expand All @@ -43,5 +43,5 @@
<ProjectReference Include="..\..\src\AWS.Deploy.ServerMode.Client\AWS.Deploy.ServerMode.Client.csproj" />
<ProjectReference Include="..\AWS.Deploy.CLI.Common.UnitTests\AWS.Deploy.CLI.Common.UnitTests.csproj" />
</ItemGroup>

</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<Nullable>enable</Nullable>
</PropertyGroup>

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>

<IsPackable>false</IsPackable>
<LangVersion>Latest</LangVersion>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>

<IsPackable>false</IsPackable>
</PropertyGroup>
Expand All @@ -17,7 +17,7 @@
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>

<PackageReference Include="coverlet.msbuild" Version="6.0.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
Expand Down
Loading