Skip to content

feat: upgrade deploy tool to net8.0 #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025

Conversation

philasmar
Copy link
Contributor

Issue #, if available:
DOTNET-8095

Description of changes:

  • Update all projects to net8.0
  • Switch S3Origin to S3BucketOrigin.WithOriginAccessControl since S3Origin is now obsolete.
  • Removed ISystemClock clock which is now obsolete

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@philasmar philasmar added the Release Not Needed Add this label if a PR does not need to be released. label May 2, 2025
@philasmar philasmar requested review from normj and GarrettBeatty May 2, 2025 00:10
Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feature/net8-upgrade@5f28fb8). Learn more about missing BASE report.

Additional details and impacted files
@@                   Coverage Diff                   @@
##             feature/net8-upgrade     #918   +/-   ##
=======================================================
  Coverage                        ?   63.59%           
=======================================================
  Files                           ?      284           
  Lines                           ?    11040           
  Branches                        ?     1537           
=======================================================
  Hits                            ?     7021           
  Misses                          ?     3467           
  Partials                        ?      552           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philasmar philasmar merged commit 33c3f79 into feature/net8-upgrade May 2, 2025
11 checks passed
@philasmar philasmar deleted the asmarp/net8-update branch May 2, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Not Needed Add this label if a PR does not need to be released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants