Skip to content

fix(aerostructural): NumPy 2.4 compatibility in the coupled solvers #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ocayon merged 1 commit into from
Oct 8, 2026
Merged

fix(aerostructural): NumPy 2.4 compatibility in the coupled solvers #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/awetrim/aerostructural/coupled/coupled_solver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1481,13 +1481,17 @@ def main(

# Angle between vectors (signed)
dot = np.clip(np.dot(vec_chord_2d, vec_wind_2d), -1.0, 1.0)
cross = np.cross(vec_chord_2d, vec_wind_2d)
# z-component of the 2-D cross product, written out: np.cross on
# 2-element vectors is deprecated since NumPy 2.0.
cross = vec_chord_2d[0] * vec_wind_2d[1] - vec_chord_2d[1] * vec_wind_2d[0]

angle = np.arctan2(cross, dot)

print(f"alpha = {np.degrees(angle):.2f}° (va vs mid-span chord)")
print(
f'alpha = {float(np.rad2deg(results_aero["alpha_at_ac"][mid_idx])):.2f}° (incl. induced velocity, from results_aero["alpha_at_ac"])'
# alpha_at_ac is one row per panel; flatten before indexing, since
# float() of a one-element array raises from NumPy 2.4 on.
f'alpha = {float(np.rad2deg(np.ravel(results_aero["alpha_at_ac"])[mid_idx])):.2f}° (incl. induced velocity, from results_aero["alpha_at_ac"])'
)

if config["structural_solver"] == "wireframe":
Expand Down
4 changes: 3 additions & 1 deletion src/awetrim/aerostructural/wireframe/coupled_solver_qsm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2035,7 +2035,9 @@ def _rotate_anderson_history(roll_deg, pitch_deg, yaw_deg):

# Angle between vectors (signed)
dot = np.clip(np.dot(vec_chord_2d, vec_wind_2d), -1.0, 1.0)
cross = np.cross(vec_chord_2d, vec_wind_2d)
# z-component of the 2-D cross product, written out: np.cross on
# 2-element vectors is deprecated since NumPy 2.0.
cross = vec_chord_2d[0] * vec_wind_2d[1] - vec_chord_2d[1] * vec_wind_2d[0]

angle = np.arctan2(cross, dot)
alpha_at_ac_mid = np.ravel(results_aero["alpha_at_ac"])[mid_idx]
Expand Down
Loading