Repository navigation
fix(aerostructural): NumPy 2.4 compatibility in the coupled solvers - #24
Merged
Merged
Conversation
run_simulation_BILLOW.py crashed on NumPy 2.4 at the per-iteration alpha print: results_aero["alpha_at_ac"] is one row per panel, so [mid_idx] is a one-element array, and float() of it raises from NumPy 2.4 on (deprecated since 1.25, a warning only up to 2.3). Flatten before indexing, as the wireframe solver already does. Both solvers also called np.cross on 2-element vectors for the same print, deprecated since NumPy 2.0; write out the 2-D cross product instead. Checked by running the test suite and both baseline scripts with both deprecations promoted to errors: the baselines run through with unchanged results (Billow 5049 N, wireframe 4518 N).
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a crash of
run_simulation_BILLOW.pyon NumPy ≥ 2.4 (TypeError: only 0-dimensional arrays can be converted to Python scalars).coupled/coupled_solver.py:results_aero["alpha_at_ac"]is one row per panel, so[mid_idx]is a one-element array;float()of it raises from NumPy 2.4 on. Flatten before indexing (the wireframe solver already did).np.crosson 2-element vectors (deprecated since NumPy 2.0) replaced by the written-out 2-D cross product.Checked with both deprecations promoted to errors: the test suite and both baseline scripts run through, and the baselines' results are unchanged (Billow 5049 N, wireframe 4518 N).