Skip to content

Adds Compiler Warning to useless @Inject #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Adds Compiler Warning to useless @Inject #889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions inject-generator/src/main/java/io/avaje/inject/generator/SimpleBeanProxyWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ private void writeFields() {
}

private void writeConstructor() {
writer.append(" @Inject\n");
writer.append(" public %s%s(", shortName, suffix);
int count = 0;
for (final String aspectName : aspects.aspectNames()) {
Expand Down Expand Up @@ -96,7 +95,6 @@ private void writeImports() {
writer.append("import %s;", Constants.INVOCATION_EXCEPTION).eol();
writer.append("import %s;", Constants.METHOD_INTERCEPTOR).eol();
writer.append("import %s;", Constants.COMPONENT).eol();
writer.append("import %s;", Constants.INJECT).eol();
writer.append("import %s;", Constants.PROXY).eol();
beanReader.writeImports(writer, packageName);
}
Expand Down
6 changes: 6 additions & 0 deletions inject-generator/src/main/java/io/avaje/inject/generator/TypeExtendsInjection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package io.avaje.inject.generator;

import static io.avaje.inject.generator.APContext.logError;
import static io.avaje.inject.generator.APContext.logWarn;
import static io.avaje.inject.generator.ProcessingContext.getImportedAspect;

import javax.lang.model.element.AnnotationMirror;
Expand Down Expand Up @@ -59,6 +60,11 @@ void read(TypeElement type) {
break;
}
}
if (injectConstructor != null
&& otherConstructors.isEmpty()
&& InjectPrism.isPresent(injectConstructor.element())) {
logWarn(injectConstructor.element(), "Remove Unused @Inject Annotation");
}
}

/** Read the annotations on the type. */
Expand Down