Adds Compiler Warning to useless @Inject

[SentryMan]

Now will warn when the @inject annotation is not needed

[rbygrave]

I don't understand the motiivation. Some people use @Inject on a constructor just to be more explicit and that would now be a warning?

What was the motivation for this?

[SentryMan]

Some people use @Inject on a constructor just to be more explicit and that would now be a warning?

It does not affect anything, so to me it's a useless addition. Even so, if you don't like it that's that (I don't care about this that much)

[rbygrave]

Hmm, yeah there are those cases of (A) Necessary for multiple constructors case and (B) As documentation to assist people reading the code with their mental model of what is going on.

So I don't see it as harmful per se and I do think there are people who like to include it even when it's unnecessary for the documentation / learning / mental model type reasons. So yes at this stage I don't think we should actively discourage that with a compiler warning.